diff --git a/course/report/completion/index.php b/course/report/completion/index.php index 5936ed3a212..0118cf1b16c 100644 --- a/course/report/completion/index.php +++ b/course/report/completion/index.php @@ -241,6 +241,9 @@ $pagingbar = ''; foreach ($initials as $initial) { $var = 'si'.$initial; + $othervar = $initial == 'first' ? 'silast' : 'sifirst'; + $othervar = $$othervar != 'all' ? "&{$othervar}={$$othervar}" : ''; + $pagingbar .= ' <div class="initialbar '.$initial.'initial">'; $pagingbar .= get_string($initial.'name').': '; @@ -248,7 +251,7 @@ foreach ($initials as $initial) { $pagingbar .= '<strong>'.get_string('all').'</strong> '; } else { - $pagingbar .= '<a href="'.$link.'">'.get_string('all').'</a> '; + $pagingbar .= "<a href=\"{$link}{$othervar}\">".get_string('all').'</a> '; } foreach ($alphabet as $letter) { @@ -256,7 +259,7 @@ foreach ($initials as $initial) { $pagingbar .= '<strong>'.$letter.'</strong> '; } else { - $pagingbar .= '<a href="'.$link.'&'.$var.'='.$letter.'">'.$letter.'</a> '; + $pagingbar .= "<a href=\"$link&$var={$letter}{$othervar}\">$letter</a> "; } } @@ -270,10 +273,15 @@ if($total > COMPLETION_REPORT_PAGE) { $pagingbar .= '<div class="paging">'; $pagingbar .= get_string('page').': '; + $sistrings = array(); + $sistrings[] = $sifirst != 'all' ? "sifirst={$sifirst}" : null; + $sistrings[] = $silast != 'all' ? "silast={$silast}" : null; + $sistring = !empty($sistrings) ? implode('&', $sistrings) : ''; + // Display previous link if ($start > 0) { $pstart = max($start - COMPLETION_REPORT_PAGE, 0); - $pagingbar .= '(<a class="previous" href="'.$link.$pstart.'">'.get_string('previous').'</a>) '; + $pagingbar .= "(<a class=\"previous\" href=\"{$link}{$pstart}{$sistring}\">".get_string('previous').'</a>) '; } // Create page links @@ -286,7 +294,7 @@ if($total > COMPLETION_REPORT_PAGE) { $pagingbar .= ' '.$curpage.' '; } else { - $pagingbar .= ' <a href="'.$link.$curstart.'">'.$curpage.'</a> '; + $pagingbar .= " <a href=\"{$link}{$curstart}{$sistring}\">$curpage</a> "; } $curstart += COMPLETION_REPORT_PAGE; @@ -295,7 +303,7 @@ if($total > COMPLETION_REPORT_PAGE) { // Display next link $nstart = $start + COMPLETION_REPORT_PAGE; if ($nstart < $total) { - $pagingbar .= ' (<a class="next" href="'.$link.$nstart.'">'.get_string('next').'</a>)'; + $pagingbar .= " (<a class=\"next\" href=\"{$link}{$nstart}{$sistring}\">".get_string('next').'</a>)'; } $pagingbar .= '</div>'; @@ -441,12 +449,15 @@ if(!$csv) { // User heading / sort option print '<th scope="col" class="completion-sortchoice" style="clear: both;">'; + + $sistring = "&silast={$silast}&sifirst={$sifirst}"; + if($firstnamesort) { print - get_string('firstname').' / <a href="./?course='.$course->id.'">'. + get_string('firstname')." / <a href=\"./?course={$course->id}{$sistring}\">". get_string('lastname').'</a>'; } else { - print '<a href="./?course='.$course->id.'&sort=firstname">'. + print "<a href=\"./?course={$course->id}&sort=firstname{$sistring}\">". get_string('firstname').'</a> / '. get_string('lastname'); } diff --git a/course/report/progress/index.php b/course/report/progress/index.php index b205c0bd46b..a45a6439c71 100644 --- a/course/report/progress/index.php +++ b/course/report/progress/index.php @@ -173,6 +173,9 @@ $pagingbar = ''; foreach ($initials as $initial) { $var = 'si'.$initial; + $othervar = $initial == 'first' ? 'silast' : 'sifirst'; + $othervar = $$othervar != 'all' ? "&{$othervar}={$$othervar}" : ''; + $pagingbar .= ' <div class="initialbar '.$initial.'initial">'; $pagingbar .= get_string($initial.'name').': '; @@ -180,7 +183,7 @@ foreach ($initials as $initial) { $pagingbar .= '<strong>'.get_string('all').'</strong> '; } else { - $pagingbar .= '<a href="'.$link.'">'.get_string('all').'</a> '; + $pagingbar .= "<a href=\"{$link}{$othervar}\">".get_string('all').'</a> '; } foreach ($alphabet as $letter) { @@ -188,7 +191,7 @@ foreach ($initials as $initial) { $pagingbar .= '<strong>'.$letter.'</strong> '; } else { - $pagingbar .= '<a href="'.$link.'&'.$var.'='.$letter.'">'.$letter.'</a> '; + $pagingbar .= "<a href=\"$link&$var={$letter}{$othervar}\">$letter</a> "; } } @@ -202,10 +205,15 @@ if($total > COMPLETION_REPORT_PAGE) { $pagingbar .= '<div class="paging">'; $pagingbar .= get_string('page').': '; + $sistrings = array(); + $sistrings[] = $sifirst != 'all' ? "sifirst={$sifirst}" : null; + $sistrings[] = $silast != 'all' ? "silast={$silast}" : null; + $sistring = !empty($sistrings) ? implode('&', $sistrings) : ''; + // Display previous link if ($start > 0) { $pstart = max($start - COMPLETION_REPORT_PAGE, 0); - $pagingbar .= '(<a class="previous" href="'.$link.$pstart.'">'.get_string('previous').'</a>) '; + $pagingbar .= "(<a class=\"previous\" href=\"{$link}{$pstart}{$sistring}\">".get_string('previous').'</a>) '; } // Create page links @@ -218,7 +226,7 @@ if($total > COMPLETION_REPORT_PAGE) { $pagingbar .= ' '.$curpage.' '; } else { - $pagingbar .= ' <a href="'.$link.$curstart.'">'.$curpage.'</a> '; + $pagingbar .= " <a href=\"{$link}{$curstart}{$sistring}\">$curpage</a> "; } $curstart += COMPLETION_REPORT_PAGE; @@ -227,7 +235,7 @@ if($total > COMPLETION_REPORT_PAGE) { // Display next link $nstart = $start + COMPLETION_REPORT_PAGE; if ($nstart < $total) { - $pagingbar .= ' (<a class="next" href="'.$link.$nstart.'">'.get_string('next').'</a>)'; + $pagingbar .= " (<a class=\"next\" href=\"{$link}{$nstart}{$sistring}\">".get_string('next').'</a>)'; } $pagingbar .= '</div>'; @@ -251,12 +259,15 @@ if(!$csv) { // User heading / sort option print '<th scope="col" class="completion-sortchoice">'; + + $sistring = "&silast={$silast}&sifirst={$sifirst}"; + if($firstnamesort) { print - get_string('firstname').' / <a href="./?course='.$course->id.'">'. + get_string('firstname')." / <a href=\"./?course={$course->id}{$sistring}\">". get_string('lastname').'</a>'; } else { - print '<a href="./?course='.$course->id.'&sort=firstname">'. + print "<a href=\"./?course={$course->id}&sort=firstname{$sistring}\">". get_string('firstname').'</a> / '. get_string('lastname'); }