From 46e944aeb317816766ecf369d037f8bad54a79e1 Mon Sep 17 00:00:00 2001
From: David Monllao <davidm@moodle.com>
Date: Wed, 24 Feb 2016 10:46:15 +0800
Subject: [PATCH] MDL-31989 admin: Search admin settings only when needed

---
 admin/settings/plugins.php | 66 ++++++++++++++++++++------------------
 1 file changed, 34 insertions(+), 32 deletions(-)

diff --git a/admin/settings/plugins.php b/admin/settings/plugins.php
index 089961be074..1e3322b1ab0 100644
--- a/admin/settings/plugins.php
+++ b/admin/settings/plugins.php
@@ -457,45 +457,47 @@ foreach ($pages as $page) {
     $ADMIN->add('reportplugins', $page);
 }
 
-// Global Search engine plugins.
-$ADMIN->add('modules', new admin_category('searchplugins', new lang_string('search', 'admin')));
-$temp = new admin_settingpage('manageglobalsearch', new lang_string('globalsearchmanage', 'admin'));
+if ($hassiteconfig) {
+    // Global Search engine plugins.
+    $ADMIN->add('modules', new admin_category('searchplugins', new lang_string('search', 'admin')));
+    $temp = new admin_settingpage('manageglobalsearch', new lang_string('globalsearchmanage', 'admin'));
 
-$pages = array();
-$engines = array();
-foreach (core_component::get_plugin_list('search') as $engine => $plugindir) {
-    $engines[$engine] = new lang_string('pluginname', 'search_' . $engine);
-    $settingspath = "$plugindir/settings.php";
-    if (file_exists($settingspath)) {
-        $settings = new admin_settingpage('search' . $engine,
-                new lang_string('pluginname', 'search_' . $engine), 'moodle/site:config');
-        include($settingspath);
-        if ($settings) {
-            $pages[] = $settings;
+    $pages = array();
+    $engines = array();
+    foreach (core_component::get_plugin_list('search') as $engine => $plugindir) {
+        $engines[$engine] = new lang_string('pluginname', 'search_' . $engine);
+        $settingspath = "$plugindir/settings.php";
+        if (file_exists($settingspath)) {
+            $settings = new admin_settingpage('search' . $engine,
+                    new lang_string('pluginname', 'search_' . $engine), 'moodle/site:config');
+            include($settingspath);
+            if ($settings) {
+                $pages[] = $settings;
+            }
         }
     }
-}
 
-// Setup status.
-$temp->add(new admin_setting_searchsetupinfo());
+    // Setup status.
+    $temp->add(new admin_setting_searchsetupinfo());
 
-// Search engine selection.
-$temp->add(new admin_setting_heading('searchengineheading', new lang_string('searchengine', 'admin'), ''));
-$temp->add(new admin_setting_configselect('searchengine',
-                            new lang_string('selectsearchengine', 'admin'), '', 'solr', $engines));
+    // Search engine selection.
+    $temp->add(new admin_setting_heading('searchengineheading', new lang_string('searchengine', 'admin'), ''));
+    $temp->add(new admin_setting_configselect('searchengine',
+                                new lang_string('selectsearchengine', 'admin'), '', 'solr', $engines));
 
-// Enable search areas.
-$temp->add(new admin_setting_heading('searchareasheading', new lang_string('availablesearchareas', 'admin'), ''));
-$searchareas = \core_search\manager::get_search_areas_list();
-foreach ($searchareas as $areaid => $searcharea) {
-    list($componentname, $varname) = $searcharea->get_config_var_name();
-    $temp->add(new admin_setting_configcheckbox($componentname . '/' . $varname . '_enabled', $searcharea->get_visible_name(true),
-        '', 1, 1, 0));
-}
-$ADMIN->add('searchplugins', $temp);
+    // Enable search areas.
+    $temp->add(new admin_setting_heading('searchareasheading', new lang_string('availablesearchareas', 'admin'), ''));
+    $searchareas = \core_search\manager::get_search_areas_list();
+    foreach ($searchareas as $areaid => $searcharea) {
+        list($componentname, $varname) = $searcharea->get_config_var_name();
+        $temp->add(new admin_setting_configcheckbox($componentname . '/' . $varname . '_enabled', $searcharea->get_visible_name(true),
+            '', 1, 1, 0));
+    }
+    $ADMIN->add('searchplugins', $temp);
 
-foreach ($pages as $page) {
-    $ADMIN->add('searchplugins', $page);
+    foreach ($pages as $page) {
+        $ADMIN->add('searchplugins', $page);
+    }
 }
 
 /// Add all admin tools