mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-22 17:02:03 +02:00
Code Issues Projects Releases Wiki Activity

search MDL-25153 fixed performance problem

Browse Source
This commit is contained in:
Aparup Banerjee 2010-12-02 06:24:50 +00:00
parent 57bedaeeea
commit 2282039660
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
search/query.php
View File

@ -339,13 +339,19 @@
$authorstr = get_string('author', 'search');
$searchables = search_collect_searchables(false, false);
//build a list of distinct user objects needed for results listing.
$hitusers = array();
foreach ($hits as $listing) {
if ($listing->doctype == 'user' and !isset($hitusers[$listing->userid])) {
$hitusers[$listing->userid] = $DB->get_record('user', array('id' => $listing->userid));
}
}
foreach ($hits as $listing) {
if ($listing->doctype == 'user'){ // A special handle for users
//TODO: this is a performance problem, fetch data elsewhere
$user = (object)array('id'=>$listing->userid);
$icon = $OUTPUT->user_picture($user);
if ($listing->doctype == 'user') { // A special handle for users
$icon = $OUTPUT->user_picture($hitusers[$listing->userid]);
} else {
$iconpath = $OUTPUT->pix_url('icon', $listing->doctype);
$icon = "<img align=\"top\" src=\"".$iconpath."\" class=\"activityicon\" alt=\"\"/>";