diff --git a/completion/tests/behat/behat_completion.php b/completion/tests/behat/behat_completion.php new file mode 100644 index 00000000000..7bf57fbf481 --- /dev/null +++ b/completion/tests/behat/behat_completion.php @@ -0,0 +1,100 @@ +. + +/** + * Completion steps definitions. + * + * @package core_completion + * @category test + * @copyright 2013 David Monllaó + * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later + */ + +// NOTE: no MOODLE_INTERNAL test here, this file may be required by behat before including /config.php. + +require_once(__DIR__ . '/../../../lib/behat/behat_base.php'); + +use Behat\Behat\Context\Step\Given as Given, + Behat\Mink\Exception\ElementNotFoundException as ElementNotFoundException; + +/** + * Steps definitions to deal with course and activities completion. + * + * @package core_completion + * @category test + * @copyright 2013 David Monllaó + * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later + */ +class behat_completion extends behat_base { + + /** + * Checks that the specified user has completed the specified activity of the current course. + * + * @Then /^"(?P(?:[^"]|\\")*)" user has completed "(?P(?:[^"]|\\")*)" activity$/ + * @param string $userfullname + * @param string $activityname + */ + public function user_has_completed_activity($userfullname, $activityname) { + + // Will throw an exception if the element can not be hovered. + $xpath = "//table[@id='completion-progress']/descendant::img[contains(@title, '" . $userfullname . ", " . $activityname . ": Completed')]"; + + return array( + new Given('I go to the current course activity completion report'), + new Given('I hover "' . $xpath . '" "xpath_element"') + ); + } + + /** + * Checks that the specified user has not completed the specified activity of the current course. + * + * @Then /^"(?P(?:[^"]|\\")*)" user has not completed "(?P(?:[^"]|\\")*)" activity$/ + * @param string $userfullname + * @param string $activityname + */ + public function user_has_not_completed_activity($userfullname, $activityname) { + + $xpath = "//table[@id='completion-progress']/descendant::img[contains(@title, '" . $userfullname . ", " . $activityname . ": Not completed')]"; + return array( + new Given('I go to the current course activity completion report'), + new Given('I hover "' . $xpath . '" "xpath_element"') + ); + + return $steps; + } + + /** + * Goes to the current course activity completion report. + * + * @Given /^I go to the current course activity completion report$/ + */ + public function go_to_the_current_course_activity_completion_report() { + + $steps = array(); + + // Expand reports node if we can't see the link. + try { + $this->find('xpath', "//*[@id='settingsnav']/descendant::li/descendant::li[not(contains(@class,'collapsed'))]/descendant::p[contains(., 'Activity completion')]"); + } catch (ElementNotFoundException $e) { + $steps[] = new Given('I expand "Reports" node'); + } + + $steps[] = new Given('I follow "Activity completion"'); + + return $steps; + } + +} diff --git a/completion/tests/behat/enable_manual_complete_mark.feature b/completion/tests/behat/enable_manual_complete_mark.feature new file mode 100644 index 00000000000..0afd58ff1e1 --- /dev/null +++ b/completion/tests/behat/enable_manual_complete_mark.feature @@ -0,0 +1,47 @@ +@core_completion +Feature: Allow students to manually mark an activity as complete + In order to let students decide when an activity is completed + As a moodle teacher + I need to allow students to mark activities as completed + + @javascript + Scenario: Mark an activity as completed + Given the following "courses" exists: + | fullname | shortname | category | + | Course 1 | C1 | 0 | + And the following "users" exists: + | username | firstname | lastname | email | + | teacher1 | Teacher | Frist | teacher1@asd.com | + | student1 | Student | First | student1@asd.com | + And the following "course enrolments" exists: + | user | course | role | + | teacher1 | C1 | editingteacher | + | student1 | C1 | student | + And I log in as "admin" + And I set the following administration settings values: + | Enable completion tracking | 1 | + | Enable conditional access | 1 | + And I log out + And I log in as "teacher1" + And I follow "Course 1" + And I turn editing mode on + And I follow "Edit settings" + And I fill the moodle form with: + | Completion tracking | Enabled, control via completion and activity settings | + | Completion tracking begins on enrolment | 1 | + And I press "Save changes" + When I add a "Forum" to section "1" and I fill the form with: + | Forum name | Test forum name | + | Description | Test forum description | + Then "Student First" user has not completed "Test forum name" activity + And I log out + And I log in as "student1" + And I follow "Course 1" + And I press "Mark as complete: Test forum name" + And I wait "3" seconds + And I log out + And I log in as "teacher1" + And I follow "Course 1" + And I expand "Reports" node + And I follow "Activity completion" + And "Student First" user has completed "Test forum name" activity diff --git a/lib/behat/behat_field_manager.php b/lib/behat/behat_field_manager.php index 01cc96560f0..a72e7536054 100644 --- a/lib/behat/behat_field_manager.php +++ b/lib/behat/behat_field_manager.php @@ -53,7 +53,6 @@ class behat_field_manager { * @return behat_form_field */ public static function get_field(NodeElement $fieldnode, $locator, Session $session) { - global $CFG; // Get the field type if is part of a moodleform. if (self::is_moodleform_field($fieldnode)) { @@ -65,6 +64,23 @@ class behat_field_manager { $type = 'field'; } + return self::get_field_instance($type, $fieldnode, $session); + } + + /** + * Returns the appropiate behat_form_field according to the provided type. + * + * It defaults to behat_form_field. + * + * @param string $type The field type (checkbox, date_selector, text...) + * @param NodeElement $fieldnode + * @param Session $session The behat session + * @return behat_form_field + */ + public static function get_field_instance($type, NodeElement $fieldnode, Session $session) { + + global $CFG; + $classname = 'behat_form_' . $type; // Fallsback on the default form field if nothing specific exists.