From ac2e962f6199e3a4a23ac2539d67109984acda15 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Luca=20B=C3=B6sch?= <luca.boesch@bfh.ch>
Date: Sat, 26 Mar 2022 07:32:33 +0100
Subject: [PATCH] MDL-74412 question: Not every column needs pr-3 in question
bank.
---
question/bank/comment/classes/comment_count_column.php | 4 ++++
question/bank/customfields/classes/custom_field_column.php | 4 ++++
.../bank/editquestion/classes/question_status_column.php | 4 ++++
question/bank/history/classes/history_action_column.php | 4 ++++
question/bank/history/classes/version_number_column.php | 4 ++++
.../bank/statistics/classes/columns/discrimination_index.php | 5 +++++
.../statistics/classes/columns/discriminative_efficiency.php | 4 ++++
question/bank/statistics/classes/columns/facility_index.php | 5 +++++
question/bank/usage/classes/question_usage_column.php | 4 ++++
question/bank/viewcreator/classes/creator_name_column.php | 4 ++++
.../classes/question_name_idnumber_tags_column.php | 4 ++++
question/classes/local/bank/column_base.php | 1 -
question/classes/local/bank/edit_menu_column.php | 5 +++++
13 files changed, 51 insertions(+), 1 deletion(-)
diff --git a/question/bank/comment/classes/comment_count_column.php b/question/bank/comment/classes/comment_count_column.php
index f9aa7c191a4..c8238fa9e94 100644
--- a/question/bank/comment/classes/comment_count_column.php
+++ b/question/bank/comment/classes/comment_count_column.php
@@ -77,4 +77,8 @@ class comment_count_column extends column_base {
echo \html_writer::tag('a', $commentcount, $attributes);
}
+ public function get_extra_classes(): array {
+ return ['pr-3'];
+ }
+
}
diff --git a/question/bank/customfields/classes/custom_field_column.php b/question/bank/customfields/classes/custom_field_column.php
index fdefab9dca3..469d6f9fceb 100644
--- a/question/bank/customfields/classes/custom_field_column.php
+++ b/question/bank/customfields/classes/custom_field_column.php
@@ -88,4 +88,8 @@ class custom_field_column extends column_base {
}
}
+ public function get_extra_classes(): array {
+ return ['pr-3'];
+ }
+
}
diff --git a/question/bank/editquestion/classes/question_status_column.php b/question/bank/editquestion/classes/question_status_column.php
index 060f5a679aa..7ef6621ddf6 100644
--- a/question/bank/editquestion/classes/question_status_column.php
+++ b/question/bank/editquestion/classes/question_status_column.php
@@ -57,4 +57,8 @@ class question_status_column extends column_base {
}
}
+ public function get_extra_classes(): array {
+ return ['pr-3'];
+ }
+
}
diff --git a/question/bank/history/classes/history_action_column.php b/question/bank/history/classes/history_action_column.php
index b3e9116c76c..21d64100054 100644
--- a/question/bank/history/classes/history_action_column.php
+++ b/question/bank/history/classes/history_action_column.php
@@ -36,6 +36,10 @@ class history_action_column extends menu_action_column_base {
$this->strpreview = get_string('history_action', 'qbank_history');
}
+ public function get_extra_classes(): array {
+ return ['pr-3'];
+ }
+
public function get_name(): string {
return 'historyaction';
}
diff --git a/question/bank/history/classes/version_number_column.php b/question/bank/history/classes/version_number_column.php
index c3c8e863393..a156223362c 100644
--- a/question/bank/history/classes/version_number_column.php
+++ b/question/bank/history/classes/version_number_column.php
@@ -40,4 +40,8 @@ class version_number_column extends column_base {
print_string('questionversiondata', 'qbank_history', $question->version);
}
+ public function get_extra_classes(): array {
+ return ['pr-3'];
+ }
+
}
diff --git a/question/bank/statistics/classes/columns/discrimination_index.php b/question/bank/statistics/classes/columns/discrimination_index.php
index 1f5b65a51e9..8046127c821 100644
--- a/question/bank/statistics/classes/columns/discrimination_index.php
+++ b/question/bank/statistics/classes/columns/discrimination_index.php
@@ -63,4 +63,9 @@ class discrimination_index extends column_base {
$discriminationindex = helper::calculate_average_question_discrimination_index($question->id);
echo $PAGE->get_renderer('qbank_statistics')->render_discrimination_index($discriminationindex);
}
+
+ public function get_extra_classes(): array {
+ return ['pr-3'];
+ }
+
}
diff --git a/question/bank/statistics/classes/columns/discriminative_efficiency.php b/question/bank/statistics/classes/columns/discriminative_efficiency.php
index 713bbf9c827..3d5a8632976 100644
--- a/question/bank/statistics/classes/columns/discriminative_efficiency.php
+++ b/question/bank/statistics/classes/columns/discriminative_efficiency.php
@@ -61,4 +61,8 @@ class discriminative_efficiency extends column_base {
$discriminativeefficiency = helper::calculate_average_question_discriminative_efficiency($question->id);
echo $PAGE->get_renderer('qbank_statistics')->render_discriminative_efficiency($discriminativeefficiency);
}
+
+ public function get_extra_classes(): array {
+ return ['pr-3'];
+ }
}
diff --git a/question/bank/statistics/classes/columns/facility_index.php b/question/bank/statistics/classes/columns/facility_index.php
index 850ddd67a14..d70fd5ea29b 100644
--- a/question/bank/statistics/classes/columns/facility_index.php
+++ b/question/bank/statistics/classes/columns/facility_index.php
@@ -61,4 +61,9 @@ class facility_index extends column_base {
$facility = helper::calculate_average_question_facility($question->id);
echo $PAGE->get_renderer('qbank_statistics')->render_facility_index($facility);
}
+
+ public function get_extra_classes(): array {
+ return ['pr-3'];
+ }
+
}
diff --git a/question/bank/usage/classes/question_usage_column.php b/question/bank/usage/classes/question_usage_column.php
index 1a31c66077e..81f2ff37a0f 100644
--- a/question/bank/usage/classes/question_usage_column.php
+++ b/question/bank/usage/classes/question_usage_column.php
@@ -58,4 +58,8 @@ class question_usage_column extends column_base {
echo \html_writer::tag('a', $usagecount, $attributes);
}
+ public function get_extra_classes(): array {
+ return ['pr-3'];
+ }
+
}
diff --git a/question/bank/viewcreator/classes/creator_name_column.php b/question/bank/viewcreator/classes/creator_name_column.php
index f00f41395c1..a9816ed5906 100644
--- a/question/bank/viewcreator/classes/creator_name_column.php
+++ b/question/bank/viewcreator/classes/creator_name_column.php
@@ -71,4 +71,8 @@ class creator_name_column extends column_base {
];
}
+ public function get_extra_classes(): array {
+ return ['pr-3'];
+ }
+
}
diff --git a/question/bank/viewquestionname/classes/question_name_idnumber_tags_column.php b/question/bank/viewquestionname/classes/question_name_idnumber_tags_column.php
index ec89b7946ee..0d2806fc87c 100644
--- a/question/bank/viewquestionname/classes/question_name_idnumber_tags_column.php
+++ b/question/bank/viewquestionname/classes/question_name_idnumber_tags_column.php
@@ -80,4 +80,8 @@ class question_name_idnumber_tags_column extends viewquestionname_column_helper
parent::load_question_tags($questions);
}
+ public function get_extra_classes(): array {
+ return ['pr-3'];
+ }
+
}
diff --git a/question/classes/local/bank/column_base.php b/question/classes/local/bank/column_base.php
index c09022c9326..3fa1c86dc46 100644
--- a/question/classes/local/bank/column_base.php
+++ b/question/classes/local/bank/column_base.php
@@ -245,7 +245,6 @@ abstract class column_base {
protected function get_classes(): string {
$classes = $this->get_extra_classes();
$classes[] = $this->get_name();
- $classes[] = 'pr-3';
return implode(' ', $classes);
}
diff --git a/question/classes/local/bank/edit_menu_column.php b/question/classes/local/bank/edit_menu_column.php
index 91ac0214f65..0c2cd32c430 100644
--- a/question/classes/local/bank/edit_menu_column.php
+++ b/question/classes/local/bank/edit_menu_column.php
@@ -105,4 +105,9 @@ class edit_menu_column extends column_base {
public function get_actions(): array {
return $this->actions;
}
+
+ public function get_extra_classes(): array {
+ return ['pr-3'];
+ }
+
}