mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-21 00:12:56 +02:00
Code Issues Projects Releases Wiki Activity

MDL-34367 core_message: removed the call to $PAGE->set_popup_notification_allowed from message/lib.php

Browse Source
This commit is contained in:
Andrew Davis 2012-10-01 11:00:48 +08:00
parent 5d6285c220
commit 26e02d7586
2 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
message/edit.php
View File

@ -34,6 +34,7 @@ $url->param('id', $userid);
$url->param('course', $course);
$PAGE->set_url($url);
$PAGE->set_popup_notification_allowed(false); // We are within the messaging system so don't show message popups
if (!$course = $DB->get_record('course', array('id' => $course))) {
print_error('invalidcourseid');

6
message/lib.php
View File

@ -26,12 +26,6 @@ require_once($CFG->libdir.'/eventslib.php');
define ('MESSAGE_SHORTLENGTH', 300);
//$PAGE isnt set if we're being loaded by cron which doesnt display popups anyway
if (isset($PAGE)) {
//TODO: this is a mega crazy hack - it is not acceptable to call anything when including lib!!! (skodak)
$PAGE->set_popup_notification_allowed(false); // We are in a message window (so don't pop up a new one)
}
define ('MESSAGE_DISCUSSION_WIDTH',600);
define ('MESSAGE_DISCUSSION_HEIGHT',500);