mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-21 00:12:56 +02:00
Code Issues Projects Releases Wiki Activity

MDL-41256 course tests: improve robustness

Browse Source 
* Fail if an exception isn't recieved
* Don't allow the possibility of an undefined variable being tested
This commit is contained in:
Dan Poltawski 2013-09-03 10:59:51 +08:00
parent c6569641e7
commit 2793260fc0
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
course/tests/courselib_test.php
View File

@ -606,19 +606,19 @@ class core_course_courselib_testcase extends advanced_testcase {
// Ensure that the shortname isn't duplicated.
try {
$created = create_course($course);
$this->fail('Exception expected');
} catch (moodle_exception $e) {
$message = $e->getMessage();
$this->assertSame(get_string('shortnametaken', 'error', $course->shortname), $e->getMessage());
}
$this->assertEquals($message, get_string('shortnametaken', 'error', $course->shortname));
// Ensure that the idnumber isn't duplicated.
$course->shortname .= '1';
try {
$created = create_course($course);
$this->fail('Exception expected');
} catch (moodle_exception $e) {
$message = $e->getMessage();
$this->assertSame(get_string('courseidnumbertaken', 'error', $course->idnumber), $e->getMessage());
}
$this->assertEquals($message, get_string('courseidnumbertaken', 'error', $course->idnumber));
}
public function test_create_course_with_generator() {