mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-22 17:02:03 +02:00
Code Issues Projects Releases Wiki Activity

quiz 'secure' mode MDL-21085 remove popup-blocker check.

Browse Source 
It was unnecessary on modern browsers, since they let thought a pop-up if you just clicked on a link, so this check was just causing an annoying and misleading alert.

Since the popupchecker was only used here, and since it was implemented in a way that does not work on all browsers, I just deleted the function. If anyone ever finds that they acutally need this functionality, they can re-implement it in a way that works.
This commit is contained in:
Tim Hunt 2010-11-02 19:49:09 +00:00
parent 222fb6e5fe
commit 29946ad595
2 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/javascript-static.js
View File

@ -714,15 +714,6 @@ M.util.get_string = function(identifier, component, a) {
//=== old legacy JS code, hopefully to be replaced soon by M.xx.yy and YUI3 code ===
function popupchecker(msg) {
var testwindow = window.open('', '', 'width=1,height=1,left=0,top=0,scrollbars=no');
if (!testwindow) {
alert(msg);
} else {
testwindow.close();
}
}
function checkall() {
var inputs = document.getElementsByTagName('input');
for (var i = 0; i < inputs.length; i++) {

3
mod/quiz/view.php
View File

@ -63,9 +63,6 @@
$USER->editing = $edit;
}
if ($accessmanager->securewindow_required($canpreview)) {
$PAGE->requires->js_function_call('popupchecker',array(get_string('popupblockerwarning', 'quiz')));
}
$PAGE->requires->yui2_lib('event');
// Note: MDL-19010 there will be further changes to printing header and blocks.