mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-21 00:12:56 +02:00
Code Issues Projects Releases Wiki Activity

MDL-64175 atto_media: update advanced settings

Browse Source 
Some OS, such as Ubuntu, are slightly changing the audio attributes,
from <audio attribute1="true"> to <audio attribute1>.
This patch is for reviewing this piece of code and covering both cases.
This commit is contained in:
Sara Arjona 2020-05-28 13:58:12 +02:00
parent 68fd8d8bdf
commit 2b860436c9
4 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/editor/atto/plugins/media/yui/build/moodle-atto_media-button/moodle-atto_media-button-debug.js vendored
View File

@ -714,7 +714,9 @@ Y.namespace('M.atto_media').Button = Y.Base.create('button', Y.M.editor_atto.Edi
*/
_getMediumProperties: function(medium) {
var boolAttr = function(elem, attr) {
return elem.getAttribute(attr) ? true : false;
// As explained in MDL-64175, some OS (like Ubuntu), are removing the value for these attributes.
// So in order to check if attr="true", we need to check if the attribute exists and if the value is empty or true.
return (elem.hasAttribute(attr) && (elem.getAttribute(attr) || elem.getAttribute(attr) === ''));
};
var tracks = {

4
lib/editor/atto/plugins/media/yui/build/moodle-atto_media-button/moodle-atto_media-button-min.js vendored
View File

File diff suppressed because one or more lines are too long

4
lib/editor/atto/plugins/media/yui/build/moodle-atto_media-button/moodle-atto_media-button.js vendored
View File

@ -714,7 +714,9 @@ Y.namespace('M.atto_media').Button = Y.Base.create('button', Y.M.editor_atto.Edi
*/
_getMediumProperties: function(medium) {
var boolAttr = function(elem, attr) {
return elem.getAttribute(attr) ? true : false;
// As explained in MDL-64175, some OS (like Ubuntu), are removing the value for these attributes.
// So in order to check if attr="true", we need to check if the attribute exists and if the value is empty or true.
return (elem.hasAttribute(attr) && (elem.getAttribute(attr) || elem.getAttribute(attr) === ''));
};
var tracks = {

4
lib/editor/atto/plugins/media/yui/src/button/js/button.js vendored
View File

@ -712,7 +712,9 @@ Y.namespace('M.atto_media').Button = Y.Base.create('button', Y.M.editor_atto.Edi
*/
_getMediumProperties: function(medium) {
var boolAttr = function(elem, attr) {
return elem.getAttribute(attr) ? true : false;
// As explained in MDL-64175, some OS (like Ubuntu), are removing the value for these attributes.
// So in order to check if attr="true", we need to check if the attribute exists and if the value is empty or true.
return (elem.hasAttribute(attr) && (elem.getAttribute(attr) || elem.getAttribute(attr) === ''));
};
var tracks = {