mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-13 04:22:07 +02:00
Code Issues Projects Releases Wiki Activity

MDL-71921 scorm: Sanitize element names before outputting track details

Browse Source
This commit is contained in:
Mihail Geshoski 2022-06-24 13:52:36 +08:00 committed by Jenkins
parent aebd3576a6
commit 2ccd1e773c
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mod/scorm/lib.php
View File

@ -499,7 +499,7 @@ function scorm_user_complete($course, $user, $mod, $scorm) {
$report .= html_writer::start_tag('li').html_writer::start_tag('ul', array('class' => $liststyle));
foreach ($usertrack as $element => $value) {
if (substr($element, 0, 3) == 'cmi') {
$report .= html_writer::tag('li', $element.' => '.s($value));
$report .= html_writer::tag('li', s($element) . ' => ' . s($value));
}
}
$report .= html_writer::end_tag('ul').html_writer::end_tag('li');

4
mod/scorm/report/userreporttracks.php
View File

@ -152,9 +152,9 @@ foreach ($trackdata as $element => $value) {
}
if (empty($string) || $table->is_downloading()) {
$row[] = $element;
$row[] = s($element);
} else {
$row[] = $element.$OUTPUT->help_icon($string, 'scorm');
$row[] = s($element) . $OUTPUT->help_icon($string, 'scorm');
}
if (strpos($element, '_time') === false) {
$row[] = s($value);