mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-05-04 23:41:50 +02:00
Code Issues Projects Releases Wiki Activity

some fixes for disabledIf and using disabledIf in course/edit_form.php

Browse Source
This commit is contained in:
jamiesensei 2006-11-28 08:04:00 +00:00
parent 04d6ac46dd
commit 2dbd640932
4 changed files with 16 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
course/edit_form.php
View File

@ -214,9 +214,10 @@ class course_edit_form extends moodleform {
$enroldatestartgrp = array(); $enroldatestartgrp = array();
$enroldatestartgrp[] = &MoodleQuickForm::createElement('date_selector', 'enrolstartdate'); $enroldatestartgrp[] = &MoodleQuickForm::createElement('date_selector', 'enrolstartdate');
$enroldatestartgrp[] = &MoodleQuickForm::createElement('checkbox', 'enrolstartdisabled', null, get_string('disable')); $enroldatestartgrp[] = &MoodleQuickForm::createElement('checkbox', 'enrolstartdisabled', null, get_string('disable'));
$mform->addGroup($enroldatestartgrp, '', get_string('enrolstartdate'), ' ', false); $mform->addGroup($enroldatestartgrp, 'enrolstartdategrp', get_string('enrolstartdate'), ' ', false);
$mform->setDefault('enrolstartdate', 0); $mform->setDefault('enrolstartdate', 0);
$mform->setDefault('enrolstartdisabled', 1); $mform->setDefault('enrolstartdisabled', 1);
$mform->disabledIf('enrolstartdategrp', 'enrolstartdisabled', 'checked');
$enroldateendgrp = array(); $enroldateendgrp = array();
$enroldateendgrp[] = &MoodleQuickForm::createElement('date_selector', 'enrolenddate'); $enroldateendgrp[] = &MoodleQuickForm::createElement('date_selector', 'enrolenddate');
@ -224,6 +225,7 @@ class course_edit_form extends moodleform {
$mform->addGroup($enroldateendgrp, 'enroldateendgrp', get_string('enrolenddate'), ' ', false); $mform->addGroup($enroldateendgrp, 'enroldateendgrp', get_string('enrolenddate'), ' ', false);
$mform->setDefault('enrolenddate', 0); $mform->setDefault('enrolenddate', 0);
$mform->setDefault('enrolenddisabled', 1); $mform->setDefault('enrolenddisabled', 1);
$mform->disabledIf('enroldateendgrp', 'enrolenddisabled', 'checked');
$periodmenu=array(); $periodmenu=array();
$periodmenu[0] = get_string('unlimited'); $periodmenu[0] = get_string('unlimited');
@ -331,16 +333,15 @@ class course_edit_form extends moodleform {
$options = array(); $options = array();
$options['0'] = get_string('no'); $options['0'] = get_string('no');
$options['1'] = get_string('yes'); $options['1'] = get_string('yes');
$mform->addElement('select', 'restrictmodules', get_string('restrictmodules'), $options, $mform->addElement('select', 'restrictmodules', get_string('restrictmodules'), $options);
array('onChange'=>"document.getElementById('id_allowedmods').disabled=".
"((this.selectedIndex==0)?true:false);"));
$mods = array(0=>get_string('allownone')); $mods = array(0=>get_string('allownone'));
$mods += get_records_menu('modules', '','','','id, name'); $mods += get_records_menu('modules', '','','','id, name');
$mform->addElement('select', 'allowedmods', get_string('to'),$mods, $mform->addElement('select', 'allowedmods', get_string('to'), $mods,
array('multiple'=>'multiple', 'size'=>'10', 'id'=>'allowedmods')); array('multiple'=>'multiple', 'size'=>'10'));
}else { $mform->disabledIf('allowedmods', 'restrictmodules', 'eq', 0);
} else {
$mform->addElement('hidden', 'restrictmodules', null); $mform->addElement('hidden', 'restrictmodules', null);
} }
if ($CFG->restrictmodulesfor == 'all') { if ($CFG->restrictmodulesfor == 'all') {
@ -352,8 +353,7 @@ class course_edit_form extends moodleform {
$mform->setType('restrictmodules', PARAM_INT); $mform->setType('restrictmodules', PARAM_INT);
//-------------------------------------------------------------------------------- //--------------------------------------------------------------------------------
$mform->addElement('submit', 'submit', get_string('savechanges')); $mform->addElement('submit', 'submitbutton', get_string('savechanges'));
//-------------------------------------------------------------------------------- //--------------------------------------------------------------------------------
$mform->addElement('hidden', 'id', null); $mform->addElement('hidden', 'id', null);
$mform->setType('id', PARAM_INT); $mform->setType('id', PARAM_INT);
@ -377,17 +377,7 @@ class course_edit_form extends moodleform {
} }
function definition_after_data(){
$mform=&$this->_form;
if ($mform->elementExists('allowedmods')){
if ($mform->exportValue('restrictmodules')!=1){
$allowedmods=&$mform->getElement('allowedmods');
$allowedmods->
updateAttributes(array('disabled'
=> 'disabled')) ;
}
}
}
/// perform some extra moodle validation /// perform some extra moodle validation
function validation($data){ function validation($data){

2
lib/form/submit.php
View File

@ -27,7 +27,7 @@ class MoodleQuickForm_submit extends HTML_QuickForm_submit
HTML_QuickForm_submit::HTML_QuickForm_submit($elementName, $value, $attributes); HTML_QuickForm_submit::HTML_QuickForm_submit($elementName, $value, $attributes);
if ('cancel'==$elementName){ if ('cancel'==$elementName){
//bypass form validation js : //bypass form validation js :
$this->updateAttributes(array('onclick'=>'this.form.submit();')); $this->updateAttributes(array('onclick'=>'return this.form.submit();'));
} }
} //end constructor } //end constructor

2
lib/formslib.php
View File

@ -850,6 +850,8 @@ function validate_' . $this->_attributes['id'] . '(frm) {
$elNames = array($group->getElementName($el->getName())); $elNames = array($group->getElementName($el->getName()));
} elseif (is_a($el, 'HTML_QuickForm_header')) { } elseif (is_a($el, 'HTML_QuickForm_header')) {
return null; return null;
} elseif (method_exists($el, 'getPrivateName')) {
return array($el->getPrivateName());
} else { } else {
$elNames = array($el->getName()); $elNames = array($el->getName());
} }

7
lib/javascript-static.js
View File

@ -98,10 +98,9 @@ function lockoptionsallsetup(formid) {
form.elements[master].oldonclick = ((form.elements[master].onclick) ? form.elements[master].onclick : function () {}); form.elements[master].oldonclick = ((form.elements[master].onclick) ? form.elements[master].onclick : function () {});
form.elements[master].oldonblur = ((form.elements[master].onblur) ? form.elements[master].onblur : function () {}); form.elements[master].oldonblur = ((form.elements[master].onblur) ? form.elements[master].onblur : function () {});
form.elements[master].oldonchange = ((form.elements[master].onchange) ? form.elements[master].onchange : function () {}); form.elements[master].oldonchange = ((form.elements[master].onchange) ? form.elements[master].onchange : function () {});
form.elements[master].oldonkeypress = ((form.elements[master].onkeypress) ? form.elements[master].onkeypress : function () {}); form.elements[master].onclick = function(){this.oldonclick(); return lockoptionsall(this.form.getAttribute('id'));};
form.elements[master].onclick = function(){this.oldonclick(); return lockoptionsall(this.form.id);}; form.elements[master].onblur = function(){this.oldonblur(); return lockoptionsall(this.form.getAttribute('id'));};
form.elements[master].onblur = function(){this.oldonblur(); return lockoptionsall(this.form.id);}; form.elements[master].onchange = function(){this.oldonchange(); return lockoptionsall(this.form.getAttribute('id'));};
form.elements[master].onchange = function(){this.oldonchange(); return lockoptionsall(this.form.id);};
} }
return lockoptionsall(formid); return lockoptionsall(formid);
} }