mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-24 01:44:27 +02:00
Code Issues Projects Releases Wiki Activity

MDL-52891 calculatedsimple question: forcing new gen. values into form

Browse Source 
* forcing new generated sets of wildcard values into the question edit form so they can be saved.
* added Behat test to check new generated values are used.
This commit is contained in:
Matthias Opitz 2024-02-21 12:31:47 +00:00
parent e567c21d6e
commit 2dce0b3b9f
2 changed files with 57 additions and 0 deletions
question/type/calculatedsimple
edit_calculatedsimple_form.php
tests/behat
generate_wildcards.feature

5
question/type/calculatedsimple/edit_calculatedsimple_form.php

@ -496,6 +496,11 @@ class qtype_calculatedsimple_edit_form extends qtype_calculated_edit_form {
if ($k > 0 || $this->outsidelimit || !empty($this->numbererrors)) {
$mform->addElement('float', "number[{$j}]", get_string(
'wildcard', 'qtype_calculatedsimple', $datasetdef->name));
// Forcing new generated sets of wildcard values into the question edit form,
// so they can be saved.
$mform->setConstant("number[{$j}]", $datasetdef->items[$i]->value);
$mform->setAdvanced("number[{$j}]", true);
if (!empty($this->numbererrors['number['.$j.']'])) {
$mform->addElement('static', "numbercomment[{$j}]", '',

52
question/type/calculatedsimple/tests/behat/generate_wildcards.feature Normal file

@ -0,0 +1,52 @@
@qtype @qtype_calculatedsimple
Feature: Test creating sets of wildcard values
As a teacher
In order to be able to update my calculated simple questions
I need to be able to create and re-create sets of wildcard values
Background:
Given the following "users" exist:
| username |
| teacher |
And the following "courses" exist:
| fullname | shortname | category |
| Course 1 | C1 | 0 |
And the following "course enrolments" exist:
| user | course | role |
| teacher | C1 | editingteacher |
And the following "question categories" exist:
| contextlevel | reference | name |
| Course | C1 | Test questions |
And the following "user preferences" exist:
| user | preference | value |
| teacher | htmleditor | textarea |
Scenario: Add a calculated simple question and re-generate different wild card values
When I am on the "Course 1" "core_question > course question bank" page logged in as teacher
And I add a "Calculated simple" question filling the form with:
| Question name | calculatedsimple-001 |
| Question text | {x1} + {x2} |
| Answer 1 formula = | {x1} + {x2} |
| Grade | 100% |
And I should see "There must be at least one wild card"
And I press "id_analyzequestion"
And I should see "You must add at least one set of wild card(s) values before you can save this question."
# Creating one set of wild card values by default.
And I press "id_addbutton"
And I should see "Wild card(s) values"
# As the wild card values are random edit them to some known values.
And I set the following fields to these values:
| number[2] | 3.5 |
| number[1] | 5.3 |
And I press "id_updatedatasets"
# Save changes and continue editing.
And I press "id_updatebutton"
Then I should see "3.5 + 5.3 = 8.80"
And I should see "Correct answer : 8.80 inside limits of true value"
# Now generate a new set of wild card values.
And I press "id_addbutton"
# Save changes and continue editing.
And I press "id_updatebutton"
# Make sure the old values are no longer stored.
Then I should not see "3.5 + 5.3 = 8.80"
And I should not see "Correct answer : 8.80 inside limits of true value"