mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-19 14:27:22 +01:00
Code Issues Projects Releases Wiki Activity

MDL-17020 dml: native pgsql driver - improved get_record and get_field - this should be faster

Browse Source
This commit is contained in:
skodak 2008-10-27 15:30:38 +00:00
parent 80ffbad34b
commit 30fff7b74f
1 changed files with 10 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
lib/dml/moodle_database.php
View File

@ -926,26 +926,21 @@ abstract class moodle_database {
* @param string $sql The SQL string you wish to be executed, should normally only return one record.
* @param array $params array of sql parameters
* @param bool $ignoremultiple ignore multiple records if found
* @return mixed a fieldset object containing the first mathcing record, or false if none found.
* @return mixed a fieldset object containing the first matching record, or false if none found.
*/
public function get_record_sql($sql, array $params=null, $ignoremultiple=false) {
$count = $ignoremultiple ? 1 : 2;
if (!$mrs = $this->get_recordset_sql($sql, $params, 0, $count)) {
return false;
}
if (!$mrs->valid()) {
$mrs->close();
if (!$records = $this->get_records_sql($sql, $params, 0, $count)) {
// error or not found
return false;
}
$return = (object)$mrs->current();
$mrs->next();
if (!$ignoremultiple and $mrs->valid()) {
if (!$ignoremultiple and count($records) > 1) {
debugging('Error: mdb->get_record() found more than one record!');
}
$mrs->close();
$return = reset($records);
return $return;
}
@ -988,12 +983,10 @@ abstract class moodle_database {
* @return mixed the specified value, or false if an error occured.
*/
public function get_field_sql($sql, array $params=null) {
if ($mrs = $this->get_recordset_sql($sql, $params, 0, 1)) {
if ($mrs->valid()) {
$record = $mrs->current();
return reset($record); // first column
}
$mrs->close();
if ($records = $this->get_records_sql($sql, $params, 0, 1)) {
$record = reset($records);
$record = (array)$record;
return reset($record); // first column
}
return false;
}