mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-13 04:22:07 +02:00
Code Issues Projects Releases Wiki Activity

MDL-46861 added missing required field areaname

Browse Source
This commit is contained in:
Paul Charsley 2014-08-19 11:10:04 +12:00
parent 1446e02f69
commit 352f3f4797
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/classes/grading_external.php
View File

@ -101,6 +101,7 @@ class core_grading_external extends external_api {
$area['cmid'] = $cmid;
$area['contextid'] = $context->id;
$area['component'] = $componentname;
$area['areaname'] = $params['areaname'];
$area['activemethod'] = $gradingmanager->get_active_method();
$area['definitions'] = array();

8
lib/tests/grading_externallib_test.php
View File

@ -141,6 +141,7 @@ class core_grading_externallib_testcase extends externallib_advanced_testcase {
$cmids = array ($cm->cmid);
$areaname = 'submissions';
$result = core_grading_external::get_definitions($cmids, $areaname);
$result = external_api::clean_returnvalue(core_grading_external::get_definitions_returns(), $result);
$this->assertEquals(1, count($result['areas']));
$this->assertEquals(1, count($result['areas'][0]['definitions']));
@ -285,6 +286,7 @@ class core_grading_externallib_testcase extends externallib_advanced_testcase {
// Call the external function.
$result = core_grading_external::get_gradingform_instances($definitionid, 0);
$result = external_api::clean_returnvalue(core_grading_external::get_gradingform_instances_returns(), $result);
$this->assertEquals(1, count($result['instances']));
$this->assertEquals($USER->id, $result['instances'][0]['raterid']);
@ -294,9 +296,9 @@ class core_grading_externallib_testcase extends externallib_advanced_testcase {
$this->assertEquals(1, count($result['instances'][0]['rubric']));
$this->assertEquals(1, count($result['instances'][0]['rubric']['criteria']));
$criteria = $result['instances'][0]['rubric']['criteria'];
$this->assertEquals($criterionid, $criteria[$criterionid]['criterionid']);
$this->assertEquals($levelid, $criteria[$criterionid]['levelid']);
$this->assertEquals('excellent work', $criteria[$criterionid]['remark']);
$this->assertEquals($criterionid, $criteria[0]['criterionid']);
$this->assertEquals($levelid, $criteria[0]['levelid']);
$this->assertEquals('excellent work', $criteria[0]['remark']);
}
/**