mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-03-21 16:10:15 +01:00
Code Issues Projects Releases Wiki Activity

MDL-75379 core: Use non-static template cache

Browse Source
This commit is contained in:
Lars Bonczek 2022-08-04 12:47:26 +02:00
parent eb84455a05
commit 35792ea06a
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/outputrenderers.php
View File

@ -75,6 +75,11 @@ class renderer_base {
*/
private $mustache;
/**
* @var array $templatecache The mustache template cache.
*/
protected $templatecache = array();
/**
* Return an instance of the mustache class.
*
@ -174,7 +179,6 @@ class renderer_base {
* @return string|boolean
*/
public function render_from_template($templatename, $context) {
static $templatecache = array();
$mustache = $this->get_mustache();
try {
@ -190,12 +194,12 @@ class renderer_base {
// e.g. aria attributes that only work with id attributes and must be
// unique in a page.
$mustache->addHelper('uniqid', new \core\output\mustache_uniqid_helper());
if (isset($templatecache[$templatename])) {
$template = $templatecache[$templatename];
if (isset($this->templatecache[$templatename])) {
$template = $this->templatecache[$templatename];
} else {
try {
$template = $mustache->loadTemplate($templatename);
$templatecache[$templatename] = $template;
$this->templatecache[$templatename] = $template;
} catch (Mustache_Exception_UnknownTemplateException $e) {
throw new moodle_exception('Unknown template: ' . $templatename);
}