mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-05 08:23:01 +02:00
Code Issues Projects Releases Wiki Activity

MDL-47777 assign: max files hard coded to setting

Browse Source 
The current file submission is hard coded to a maximum of 20 files
possible.  While the user can choose a number less than 20, the maximum
is still set in code.  This converts the hard coded 20 to a site setting
defaulting to 20.
This commit is contained in:
Syxton 2014-10-22 08:24:30 -04:00
parent b49de5d930
commit 35e7ad6a60
3 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mod/assign/submission/file/lang/en/assignsubmission_file.php
View File

@ -32,6 +32,8 @@ $string['enabled_help'] = 'If enabled, students are able to upload one or more f
$string['eventassessableuploaded'] = 'A file has been uploaded.';
$string['file'] = 'File submissions';
$string['maxbytes'] = 'Maximum file size';
$string['maxfiles'] = 'Maximum files per submission';
$string['maxfiles_help'] = 'If file submissions are enabled, each assignment can be set to accept up to this number of files for their submission.';
$string['maxfilessubmission'] = 'Maximum number of uploaded files';
$string['maxfilessubmission_help'] = 'If file submissions are enabled, each student will be able to upload up to this number of files for their submission.';
$string['maximumsubmissionsize'] = 'Maximum submission size';

3
mod/assign/submission/file/locallib.php
View File

@ -29,7 +29,6 @@ require_once($CFG->libdir.'/eventslib.php');
defined('MOODLE_INTERNAL') || die();
// File areas for file submission assignment.
define('ASSIGNSUBMISSION_FILE_MAXFILES', 20);
define('ASSIGNSUBMISSION_FILE_MAXSUMMARYFILES', 5);
define('ASSIGNSUBMISSION_FILE_FILEAREA', 'submission_files');
@ -75,7 +74,7 @@ class assign_submission_file extends assign_submission_plugin {
$settings = array();
$options = array();
for ($i = 1; $i <= ASSIGNSUBMISSION_FILE_MAXFILES; $i++) {
for ($i = 1; $i <= get_config('assignsubmission_file', 'maxfiles'); $i++) {
$options[$i] = $i;
}

4
mod/assign/submission/file/settings.php
View File

@ -28,6 +28,10 @@ $settings->add(new admin_setting_configcheckbox('assignsubmission_file/default',
new lang_string('default', 'assignsubmission_file'),
new lang_string('default_help', 'assignsubmission_file'), 1));
$settings->add(new admin_setting_configtext('assignsubmission_file/maxfiles',
new lang_string('maxfiles', 'assignsubmission_file'),
new lang_string('maxfiles_help', 'assignsubmission_file'), 20, PARAM_INT));
if (isset($CFG->maxbytes)) {
$name = new lang_string('maximumsubmissionsize', 'assignsubmission_file');