mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-03-14 20:50:21 +01:00
Code Issues Projects Releases Wiki Activity

MDL-83046 course: Add non-delegated sections before delegated ones

Browse Source
This commit is contained in:
james-cnz 2024-09-09 13:20:36 +12:00
parent f86b97fdd6
commit 36c8faede8
2 changed files with 40 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
course/format/classes/local/sectionactions.php
View File

@ -162,11 +162,11 @@ class sectionactions extends baseactions {
*
* @param int $position The position to add to, 0 means to the end.
* @param bool $skipcheck the check has already been made and we know that the section with this position does not exist
* @return stdClass created section object)
* @return stdClass created section object
*/
public function create(int $position = 0, bool $skipcheck = false): stdClass {
$record = (object) [
'section' => $position,
'section' => ($position == 0 && !$skipcheck) ? null : $position,
];
return $this->create_from_object($record, $skipcheck);
}

38
course/format/tests/local/sectionactions_test.php
View File

@ -901,4 +901,42 @@ class sectionactions_test extends \advanced_testcase {
$sectioninfo = get_fast_modinfo($course->id)->get_section_info_by_id($section->id);
$this->assertEquals('null_name', $sectioninfo->name);
}
/**
* Test that the position of a new section in a course with deleghated sections.
* @covers ::create
* @covers ::create_delegated
*/
public function test_create_position(): void {
global $DB, $CFG;
$this->resetAfterTest();
require_once($CFG->libdir . '/tests/fixtures/sectiondelegatetest.php');
$course = $this->getDataGenerator()->create_course(['format' => 'topics', 'numsections' => 1]);
$section1 = get_fast_modinfo($course->id)->get_section_info(1);
$sectionactions = new sectionactions($course);
$delegatedsection1 = $sectionactions->create_delegated('test_component', 1);
$delegatedsection2 = $sectionactions->create_delegated('test_component', 2);
$this->assertEquals(2, $delegatedsection1->section);
$this->assertEquals(3, $delegatedsection2->section);
// Create some regular sections with zero and none param.
$newsection1 = $sectionactions->create(0);
$newsection2 = $sectionactions->create();
$this->assertEquals(2, $newsection1->section);
$this->assertEquals(3, $newsection2->section);
// Check the section order.
$section = $sectioninfo = get_fast_modinfo($course->id)->get_section_info_all();
$this->assertEquals($section1->id, $section[1]->id);
$this->assertEquals($newsection1->id, $section[2]->id);
$this->assertEquals($newsection2->id, $section[3]->id);
$this->assertEquals($delegatedsection1->id, $section[4]->id);
$this->assertEquals($delegatedsection2->id, $section[5]->id);
}
}