mirror of
https://github.com/moodle/moodle.git
synced 2025-03-14 04:30:15 +01:00
MDL-14591: improvements to configuring already-broken portfolio plugins
This commit is contained in:
parent
40f6f97f76
commit
36facf2e0b
@ -1725,9 +1725,6 @@ final class portfolio_admin_form extends moodleform {
|
||||
$mform->addElement('hidden', 'new', $this->plugin);
|
||||
$mform->addElement('hidden', 'plugin', $this->plugin);
|
||||
|
||||
$mform->addElement('text', 'name', get_string('name'), 'maxlength="100" size="30"');
|
||||
$mform->addRule('name', $strrequired, 'required', null, 'client');
|
||||
|
||||
// let the plugin add the fields they want (either statically or not)
|
||||
if (portfolio_static_function($this->plugin, 'has_admin_config')) {
|
||||
if (!$this->instance) {
|
||||
@ -1737,10 +1734,16 @@ final class portfolio_admin_form extends moodleform {
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
if (isset($result) && is_string($result)) { // something went wrong, stop
|
||||
throw new portfolio_exception($result, 'portfolio_' . $this->plugin, $CFG->wwwroot . '/' . $CFG->admin . '/portfolio.php');
|
||||
$mform->addElement('static', 'insane', '', get_string($result, 'portfolio_' . $this->plugin)); //, get_string($result, 'portfolio_' . $this->plugin));
|
||||
//throw new portfolio_exception($result, 'portfolio_' . $this->plugin, $CFG->wwwroot . '/' . $CFG->admin . '/portfolio.php');
|
||||
}
|
||||
|
||||
$mform->addElement('text', 'name', get_string('name'), 'maxlength="100" size="30"');
|
||||
$mform->addRule('name', $strrequired, 'required', null, 'client');
|
||||
|
||||
|
||||
// and set the data if we have some.
|
||||
if ($this->instance) {
|
||||
$data = array('name' => $this->instance->get('name'));
|
||||
|
Loading…
x
Reference in New Issue
Block a user