From 437ffc9f46ad5744d9bc0413ae20eb6965878d61 Mon Sep 17 00:00:00 2001
From: cescobedo <carlos.escobedo@gmail.com>
Date: Wed, 11 Jul 2018 11:11:33 +0200
Subject: [PATCH] MDL-53808 external_api: Remove external_function_info

---
 lib/deprecatedlib.php | 14 +++-----------
 lib/upgrade.txt       |  6 ++++++
 2 files changed, 9 insertions(+), 11 deletions(-)

diff --git a/lib/deprecatedlib.php b/lib/deprecatedlib.php
index d479b7189e1..9e9b5198a71 100644
--- a/lib/deprecatedlib.php
+++ b/lib/deprecatedlib.php
@@ -4131,19 +4131,11 @@ function site_scale_used($scaleid, &$courses) {
 }
 
 /**
- * Returns detailed function information
- *
- * @deprecated since Moodle 3.1
- * @param string|object $function name of external function or record from external_function
- * @param int $strictness IGNORE_MISSING means compatible mode, false returned if record not found, debug message if more found;
- *                        MUST_EXIST means throw exception if no record or multiple records found
- * @return stdClass description or false if not found or exception thrown
- * @since Moodle 2.0
+ * @deprecated since Moodle 3.1. Use external_api::external_function_info().
  */
 function external_function_info($function, $strictness=MUST_EXIST) {
-    debugging('external_function_info() is deprecated. Please use external_api::external_function_info() instead.',
-              DEBUG_DEVELOPER);
-    return external_api::external_function_info($function, $strictness);
+    throw new coding_exception('external_function_info() can not be used any'.
+        'more. Please use external_api::external_function_info() instead.');
 }
 
 /**
diff --git a/lib/upgrade.txt b/lib/upgrade.txt
index 5d29d4ccce9..be7297dea27 100644
--- a/lib/upgrade.txt
+++ b/lib/upgrade.txt
@@ -1,6 +1,12 @@
 This files describes API changes in core libraries and APIs,
 information provided here is intended especially for developers.
 
+=== 3.6 ===
+
+* The following functions have been finally deprecated and can not be used any more:
+
+- external_function_info()
+
 === 3.5 ===
 
 * There is a new privacy API that every subsystem and plugin has to implement so that the site can become GDPR