mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-03-24 17:40:26 +01:00
Code Issues Projects Releases Wiki Activity

MDL-77229 lesson: Fix error for empty responses (numerical pagetype)

Browse Source
This commit is contained in:
Juan Leyva 2023-04-20 11:13:23 +02:00
parent 38c35247e9
commit 39084a098b
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
mod/lesson/pagetypes/numerical.php
View File

@ -255,9 +255,12 @@ class lesson_page_type_numerical extends lesson_page {
$total = $stats["total"];
unset($stats["total"]);
foreach ($stats as $valentered => $ntimes) {
$valformatted = '';
if (!is_null($valentered) && trim($valentered) !== '') { // Empty response, 0 could be ok.
$valformatted = s(format_float($valentered, strlen($valentered), true, true));
}
$data = '<input class="form-control" type="text" size="50" ' .
'disabled="disabled" readonly="readonly" value="'.
s(format_float($valentered, strlen($valentered), true, true)).'" />';
'disabled="disabled" readonly="readonly" value="'. $valformatted .'" />';
$percent = $ntimes / $total * 100;
$percent = round($percent, 2);
$percent .= "% ".get_string("enteredthis", "lesson");
@ -270,9 +273,12 @@ class lesson_page_type_numerical extends lesson_page {
} else if ($useranswer != null && ($answer->id == $useranswer->answerid || ($answer == end($answers) &&
empty($answerdata->answers)))) {
// Get in here when the user answered or for the last answer.
$valformatted = '';
if (!is_null($useranswer->useranswer) && trim($useranswer->useranswer) !== '') { // Empty response, 0 could be ok.
$valformatted = s(format_float($useranswer->useranswer, strlen($useranswer->useranswer), true, true));
}
$data = '<input class="form-control" type="text" size="50" ' .
'disabled="disabled" readonly="readonly" value="'.
s(format_float($useranswer->useranswer, strlen($useranswer->useranswer), true, true)).'">';
'disabled="disabled" readonly="readonly" value="' . $valformatted .'">';
if (isset($pagestats[$this->properties->id][$useranswer->useranswer])) {
$percent = $pagestats[$this->properties->id][$useranswer->useranswer] / $pagestats[$this->properties->id]["total"] * 100;
$percent = round($percent, 2);