mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-18 05:58:34 +01:00
Code Issues Projects Releases Wiki Activity

MDL-63887 auth_ldap: fix unclean exit from sync when users not found

Browse Source 
We should return, not exit, and we should clean up before we do.
This commit is contained in:
Jake Dallimore 2018-12-12 08:53:35 +08:00
parent 84e8e17820
commit 39ac02f424
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
auth/ldap/auth.php
View File

@ -753,7 +753,9 @@ class auth_plugin_ldap extends auth_plugin_base {
$count = $DB->count_records_sql('SELECT COUNT(username) AS count, 1 FROM {tmp_extuser}');
if ($count < 1) {
print_string('didntgetusersfromldap', 'auth_ldap');
exit;
$dbman->drop_table($table);
$this->ldap_close();
return false;
} else {
print_string('gotcountrecordsfromldap', 'auth_ldap', $count);
}