mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-18 05:58:34 +01:00
Code Issues Projects Releases Wiki Activity

MDL-74718 webdav: correct the loop when reading chunks

Browse Source 
Adjusted the condition while reading the streams
in chunks. Read till the end to make sure we have got all
the data. Else we might not get all the data to show
in file picker.
This commit is contained in:
Sujith Haridasan 2022-05-12 18:45:17 +05:30
parent 5500d143f4
commit 3ad2833dd9
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/webdavlib.php
View File

@ -1561,7 +1561,7 @@ EOD;
$chunk_size = ($mod == $max_chunk_size ? $max_chunk_size : $matches[1] - strlen($chunk));
$chunk .= fread($this->sock, $chunk_size);
$this->_error_log('mod: ' . $mod . ' chunk: ' . $chunk_size . ' total: ' . strlen($chunk));
} while ($mod == $max_chunk_size);
} while (strlen($chunk) < $matches[1]);
}
self::update_file_or_buffer($chunk, $fp, $buffer);
break;
@ -1586,11 +1586,7 @@ EOD;
self::update_file_or_buffer($chunk, $fp, $buffer);
$loadsize += strlen($chunk);
$this->_error_log('mod: ' . $mod . ' chunk: ' . $chunk_size . ' total: ' . $loadsize);
} while ($mod == $max_chunk_size);
if ($loadsize < $matches[1]) {
$chunk = fread($this->sock, $matches[1] - $loadsize);
self::update_file_or_buffer($chunk, $fp, $buffer);
}
} while ($matches[1] > $loadsize);
break;
// check for 204 No Content