From 3b73ba8fa44f380148346a23717f2322499ce9ee Mon Sep 17 00:00:00 2001 From: Rajesh Taneja Date: Mon, 29 Aug 2016 11:54:36 +0800 Subject: [PATCH] MDL-55749 badges: define global before using it --- badges/criteria/award_criteria_activity.php | 2 +- badges/criteria/award_criteria_course.php | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/badges/criteria/award_criteria_activity.php b/badges/criteria/award_criteria_activity.php index ca099368143..171361b062e 100644 --- a/badges/criteria/award_criteria_activity.php +++ b/badges/criteria/award_criteria_activity.php @@ -48,7 +48,7 @@ class award_criteria_activity extends award_criteria { $this->course = $DB->get_record_sql('SELECT c.id, c.enablecompletion, c.cacherev, c.startdate FROM {badge} b INNER JOIN {course} c ON b.courseid = c.id - WHERE b.id = :badgeid ', array('badgeid' => $this->badgeid)); + WHERE b.id = :badgeid ', array('badgeid' => $this->badgeid), MUST_EXIST); $this->courseid = $this->course->id; } diff --git a/badges/criteria/award_criteria_course.php b/badges/criteria/award_criteria_course.php index 88625077983..c8ae554a2a6 100644 --- a/badges/criteria/award_criteria_course.php +++ b/badges/criteria/award_criteria_course.php @@ -50,7 +50,7 @@ class award_criteria_course extends award_criteria { $this->course = $DB->get_record_sql('SELECT c.id, c.enablecompletion, c.cacherev, c.startdate FROM {badge} b INNER JOIN {course} c ON b.courseid = c.id - WHERE b.id = :badgeid ', array('badgeid' => $this->badgeid)); + WHERE b.id = :badgeid ', array('badgeid' => $this->badgeid), MUST_EXIST); $this->courseid = $this->course->id; } @@ -95,7 +95,7 @@ class award_criteria_course extends award_criteria { * @return string */ public function get_details($short = '') { - global $DB; + global $DB, $OUTPUT; $param = reset($this->params); $course = $DB->get_record('course', array('id' => $param['course']));