mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-14 04:52:36 +02:00
Code Issues Projects Releases Wiki Activity

MDL-75415 mod_bigbluebuttonbn: Fix session times

Browse Source
This commit is contained in:
Shamiso.Jaravaza 2022-11-03 11:25:02 -06:00
parent fa7a55aa5d
commit 3bd76aea67
2 changed files with 7 additions and 1 deletions
mod/bigbluebuttonbn
classes
meeting.php
tests
meeting_test.php

3
mod/bigbluebuttonbn/classes/meeting.php

@ -255,7 +255,8 @@ class meeting {
!$instance->has_user_limit_been_reached($participantcount)
|| !$instance->does_current_user_count_towards_user_limit()
);
$canjoin = $canjoin && ($instance->is_currently_open() || $instance->user_can_force_join());
// User should only join during scheduled session start and end time, if defined.
$canjoin = $canjoin && ($instance->is_currently_open());
// Double check that the user has the capabilities to join.
$canjoin = $canjoin && $instance->can_join();
$meetinginfo->canjoin = $canjoin;

5
mod/bigbluebuttonbn/tests/meeting_test.php

@ -217,10 +217,15 @@ class meeting_test extends \advanced_testcase {
$this->setUser($useringroup);
$meeting->update_cache();
$this->assertEquals($canjoin['useringroup'], $meeting->can_join());
// We check that admin can not join outside opening/closing times either.
$this->setAdminUser();
$this->assertEquals(false, $meeting->can_join());
if ($groupname) {
$this->setUser($usernotingroup);
$meeting->update_cache();
$this->assertEquals($canjoin['usernotingroup'], $meeting->can_join());
$this->setAdminUser();
$this->assertEquals(false, $meeting->can_join());
}
}