mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-24 01:44:27 +02:00
Code Issues Projects Releases Wiki Activity

MDL-57063 backup: Do not try to set default value on locked setting

Browse Source 
We cannot set a default value on settings which are 'config' or
'permission' locked or an exception will be thrown from
base_setting::set_value.
This commit is contained in:
Frederic Massart 2016-11-21 11:03:41 +08:00
parent 30cfed3731
commit 3d3fb328b4
No known key found for this signature in database
GPG Key ID: AC343CE142B12FB9
1 changed files with 3 additions and 1 deletions

4
backup/util/dbops/backup_controller_dbops.class.php

@ -628,7 +628,9 @@ abstract class backup_controller_dbops extends backup_dbops {
$locked = $uselocks && (get_config('backup', $config.'_locked') == true);
if ($plan->setting_exists($settingname)) {
$setting = $plan->get_setting($settingname);
if ($setting->get_value() != $value || 1==1) {
// We can only update the setting if it isn't already locked by config or permission.
if ($setting->get_status() !== base_setting::LOCKED_BY_CONFIG
&& $setting->get_status() !== base_setting::LOCKED_BY_PERMISSION) {
$setting->set_value($value);
if ($locked) {
$setting->set_status(base_setting::LOCKED_BY_CONFIG);