mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-21 16:32:18 +02:00
Code Issues Projects Releases Wiki Activity

MDL-47353 gradereport_grader: Fix header offset logic for floating headers

Browse Source 
This is necessary for themes with non-fixed navbars to work with the
grader report, otherwise headers will be hidden.

This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
This commit is contained in:
Dave Cooper 2014-10-03 12:12:57 +08:00 committed by Andrew Nicols
parent 6821f7310c
commit 3d8ef7c65d
5 changed files with 24 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
grade/report/grader/yui/build/moodle-gradereport_grader-gradereporttable/moodle-gradereport_grader-gradereporttable-debug.js vendored
View File

@ -485,6 +485,13 @@ FloatingHeaders.prototype = {
if (header) {
if (header.getComputedStyle('position') === 'fixed') {
this.pageHeaderHeight = header.get(OFFSETHEIGHT);
} else {
var navbar = Y.one('.navbar');
if (navbar) {
// If the navbar exists and isn't fixed, we need to offset the page header to accommodate for it.
this.pageHeaderHeight = navbar.get(OFFSETHEIGHT);
}
}
}
},

4
grade/report/grader/yui/build/moodle-gradereport_grader-gradereporttable/moodle-gradereport_grader-gradereporttable-min.js vendored
View File

File diff suppressed because one or more lines are too long

7
grade/report/grader/yui/build/moodle-gradereport_grader-gradereporttable/moodle-gradereport_grader-gradereporttable.js vendored
View File

@ -485,6 +485,13 @@ FloatingHeaders.prototype = {
if (header) {
if (header.getComputedStyle('position') === 'fixed') {
this.pageHeaderHeight = header.get(OFFSETHEIGHT);
} else {
var navbar = Y.one('.navbar');
if (navbar) {
// If the navbar exists and isn't fixed, we need to offset the page header to accommodate for it.
this.pageHeaderHeight = navbar.get(OFFSETHEIGHT);
}
}
}
},

7
grade/report/grader/yui/src/gradereporttable/js/floatingheaders.js vendored
View File

@ -342,6 +342,13 @@ FloatingHeaders.prototype = {
if (header) {
if (header.getComputedStyle('position') === 'fixed') {
this.pageHeaderHeight = header.get(OFFSETHEIGHT);
} else {
var navbar = Y.one('.navbar');
if (navbar) {
// If the navbar exists and isn't fixed, we need to offset the page header to accommodate for it.
this.pageHeaderHeight = navbar.get(OFFSETHEIGHT);
}
}
}
},

2
theme/upgrade.txt
View File

@ -11,7 +11,7 @@ information provided here is intended especially for theme designer.
* On calendar view screen the course selector and new event button have been swapped, custom CSS for .path-calendar might be affected.
* The functions search_listing() and search_pagination() in the core_course_management_renderer class take the searched string
as an extra parameter - see MDL-46902.
* Themes with non-fixed headers must have the .navbar class in their navbar in order for floating headers in the grader report to work - see MDL-46658.
=== 2.7 ===