mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-18 22:08:20 +01:00
Code Issues Projects Releases Wiki Activity

MDL-42858 Course Management: fix regression for subcategories visibility

Browse Source
This commit is contained in:
rwijaya 2013-11-21 15:32:50 +08:00
parent b58bc15af5
commit 3e57883c5c
4 changed files with 1 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
course/classes/management/helper.php
View File

@ -622,10 +622,6 @@ class helper {
if (!$category->can_change_visibility()) { if (!$category->can_change_visibility()) {
throw new \moodle_exception('permissiondenied', 'error', '', null, 'coursecat::can_change_visbility'); throw new \moodle_exception('permissiondenied', 'error', '', null, 'coursecat::can_change_visbility');
} }
if ((int)$category->get_parent_coursecat()->visible === 0) {
// You cannot mark a category visible if its parent is hidden.
return false;
}
$category->show(); $category->show();
return true; return true;
} }

3
theme/base/style/course.css
View File

@ -463,14 +463,11 @@ input.titleeditor { vertical-align: text-bottom; }
.dir-rtl #course-category-listings .listitem > div > .float-right {float:left;text-align:left;} .dir-rtl #course-category-listings .listitem > div > .float-right {float:left;text-align:left;}
#course-category-listings .listitem[data-visible="0"], #course-category-listings .listitem[data-visible="0"],
#course-category-listings .listitem[data-visible="0"] a.categoryname,
#course-category-listings .listitem[data-visible="0"] > div > a {color:#AAA;} #course-category-listings .listitem[data-visible="0"] > div > a {color:#AAA;}
#course-category-listings .listitem > div .item-actions .action-hide, #course-category-listings .listitem > div .item-actions .action-hide,
#course-category-listings .listitem[data-visible="0"] > div .item-actions .action-show {display:inline;} #course-category-listings .listitem[data-visible="0"] > div .item-actions .action-show {display:inline;}
#course-category-listings .listitem > div .item-actions .action-show, #course-category-listings .listitem > div .item-actions .action-show,
#course-category-listings .listitem[data-visible="0"] > div .item-actions .action-hide, #course-category-listings .listitem[data-visible="0"] > div .item-actions .action-hide,
#course-category-listings .listitem[data-visible="0"] > ul .item-actions.category-item-actions .action-hide,
#course-category-listings .listitem[data-visible="0"] > ul .item-actions.category-item-actions .action-show,
#category-listing .listitem:first-child > div .item-actions .action-moveup, #category-listing .listitem:first-child > div .item-actions .action-moveup,
#category-listing .listitem:last-child > div .item-actions .action-movedown, #category-listing .listitem:last-child > div .item-actions .action-movedown,

10
theme/bootstrapbase/less/moodle/course.less
View File

@ -967,9 +967,6 @@ span.editinstructions {
// The category or course is hidden. // The category or course is hidden.
&[data-visible="0"] { &[data-visible="0"] {
.muted; .muted;
a.categoryname {
.muted;
}
> div { > div {
> a { > a {
.muted; .muted;
@ -983,13 +980,6 @@ span.editinstructions {
} }
} }
} }
> ul .item-actions.category-item-actions {
// If the category is hidden hide both show and hide icons for sub categories.
.action-hide,
.action-show {
display: none;
}
}
} }
&.highlight { &.highlight {
background-color:transparent; background-color:transparent;

2
theme/bootstrapbase/style/moodle.css
View File

File diff suppressed because one or more lines are too long