mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-22 08:55:15 +02:00
Code Issues Projects Releases Wiki Activity

MDL-75669 qbank: Using boostrap attributes instead of title

Browse Source 
Bootstrap5 documents that, for tooltips and when title is used, Popper
will replace it automatically with data-bs-title when the element is rendered.
So using title makes no sense because Popper will replace it. We are using
data-bs-original-title instead.
This commit is contained in:
Amaia Anabitarte 2025-01-17 10:37:14 +01:00 committed by Mikel Martín
parent 709273df45
commit 3f1fca28fc
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
question/bank/managecategories/templates/newchild.mustache
View File

@ -30,8 +30,8 @@
}}
<span
class="qbank_managecategories-newchild"
title="{{newchildtooltip}}"
data-parent="{{categoryid}}"
data-bs-original-title="{{newchildtooltip}}"
data-bs-toggle="tooltip"
data-bs-trigger="manual"
data-bs-placement="top"

2
question/bank/managecategories/tests/behat/question_categories.feature
View File

@ -69,7 +69,7 @@ Feature: A teacher can put questions in categories in the question bank
Scenario: An empty question category can be deleted
When I am on the "Qbank 1" "core_question > question categories" page
And I should see "Subcategory & < > \" ' &amp;"
And the "title" attribute of "span.qbank_managecategories-newchild.dropready" "css_element" should contain "As new child of Subcategory & < > \" ' &amp;"
And the "data-bs-original-title" attribute of "span.qbank_managecategories-newchild.dropready" "css_element" should contain "As new child of Subcategory & < > \" ' &amp;"
And I open the action menu in "Subcategory" "list_item"
And I choose "Delete" in the open action menu
And I click on "Delete" "button" in the "Delete" "dialogue"