mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-19 07:25:30 +02:00
Code Issues Projects Releases Wiki Activity

MDL-84879 core: Remove stacktrace args from exceptions

Browse Source
This commit is contained in:
Andrew Nicols 2025-03-14 17:16:00 +08:00 committed by Jun Pataleta
parent a2374ee968
commit 41917db65e
No known key found for this signature in database
GPG Key ID: F83510526D99E2C7
3 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/classes/router/response/exception_response.php
View File

@ -123,7 +123,10 @@ abstract class exception_response extends \core\router\schema\response\response
): array {
$data = [
'message' => $exception->getMessage(),
'stacktrace' => $exception->getTrace(),
'stacktrace' => array_map(
fn ($frame): array => array_filter($frame, fn ($key) => $key !== 'args', ARRAY_FILTER_USE_KEY),
$exception->getTrace(),
),
];
if (is_a($exception, \moodle_exception::class)) {

2
lib/setup.php
View File

@ -769,9 +769,11 @@ if (!isset($CFG->debugdisplay)) {
// Some parts of Moodle cannot display errors and debug at all.
ini_set('display_errors', '0');
ini_set('log_errors', '1');
ini_set('zend.exception_ignore_args', '1');
} else if (empty($CFG->debugdisplay)) {
ini_set('display_errors', '0');
ini_set('log_errors', '1');
ini_set('zend.exception_ignore_args', '1');
} else {
// This is very problematic in XHTML strict mode!
ini_set('display_errors', '1');

3
lib/tests/classes/router/route_testcase.php
View File

@ -425,6 +425,9 @@ abstract class route_testcase extends \advanced_testcase {
$payload = $this->decode_response($response);
$this->assertObjectHasProperty('message', $payload);
$this->assertObjectHasProperty('stacktrace', $payload);
foreach ($payload->stacktrace as $frame) {
$this->assertObjectNotHasProperty('args', $frame);
}
}
/**