From 146dbacc45b9bb48583a9926cdef534bf09f3bde Mon Sep 17 00:00:00 2001 From: Rajesh Taneja Date: Mon, 1 Dec 2014 11:24:04 +0800 Subject: [PATCH 1/2] MDL-48426 behat: Wait for redirection after save After saving wiki comment, page is redirected Make sure to wait for redirection after save to avoid random fails --- mod/wiki/tests/behat/wiki_comments.feature | 1 + 1 file changed, 1 insertion(+) diff --git a/mod/wiki/tests/behat/wiki_comments.feature b/mod/wiki/tests/behat/wiki_comments.feature index 4ffa1a1aed7..afd3b499c82 100644 --- a/mod/wiki/tests/behat/wiki_comments.feature +++ b/mod/wiki/tests/behat/wiki_comments.feature @@ -40,6 +40,7 @@ Feature: Users can comment on wiki pages And I set the following fields to these values: | Comment | student 1 original comment | And I press "Save" + And I wait to be redirected @javascript Scenario: Student can edit and delete their own comment From 55f473410004b38a8909f8afe71916bfb3707c5f Mon Sep 17 00:00:00 2001 From: Rajesh Taneja Date: Mon, 1 Dec 2014 12:39:42 +0800 Subject: [PATCH 2/2] MDL-48426 behat: soft-reset mink session before scenario --- lib/tests/behat/behat_hooks.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/tests/behat/behat_hooks.php b/lib/tests/behat/behat_hooks.php index e7f64f0b77f..6e2653f9ed6 100644 --- a/lib/tests/behat/behat_hooks.php +++ b/lib/tests/behat/behat_hooks.php @@ -193,6 +193,9 @@ class behat_hooks extends behat_base { behat_context_helper::set_session($session); } + // Reset mink session between the scenarios. + $session->reset(); + // Reset $SESSION. \core\session\manager::init_empty_session();