mirror of
https://github.com/moodle/moodle.git
synced 2025-04-15 13:33:52 +02:00
Merge branch 'MDL-31841_feedback_align' of git://github.com/andyjdavis/moodle
This commit is contained in:
commit
44f24f1351
@ -312,6 +312,7 @@ class grade_report_user extends grade_report {
|
||||
$hidden = '';
|
||||
$excluded = '';
|
||||
$class = '';
|
||||
$classfeedback = '';
|
||||
|
||||
// If this is a hidden grade category, hide it completely from the user
|
||||
if ($type == 'category' && $grade_object->is_hidden() && !$this->canviewhidden && (
|
||||
@ -368,6 +369,10 @@ class grade_report_user extends grade_report {
|
||||
/// Actual Grade
|
||||
$gradeval = $grade_grade->finalgrade;
|
||||
|
||||
if ($this->showfeedback) {
|
||||
// Copy $class before appending itemcenter as feedback should not be centered
|
||||
$classfeedback = $class;
|
||||
}
|
||||
$class .= " itemcenter ";
|
||||
if ($this->showweight) {
|
||||
$data['weight']['class'] = $class;
|
||||
@ -477,13 +482,13 @@ class grade_report_user extends grade_report {
|
||||
// Feedback
|
||||
if ($this->showfeedback) {
|
||||
if ($grade_grade->overridden > 0 AND ($type == 'categoryitem' OR $type == 'courseitem')) {
|
||||
$data['feedback']['class'] = $class.' feedbacktext';
|
||||
$data['feedback']['class'] = $classfeedback.' feedbacktext';
|
||||
$data['feedback']['content'] = get_string('overridden', 'grades').': ' . format_text($grade_grade->feedback, $grade_grade->feedbackformat);
|
||||
} else if (empty($grade_grade->feedback) or (!$this->canviewhidden and $grade_grade->is_hidden())) {
|
||||
$data['feedback']['class'] = $class.' feedbacktext';
|
||||
$data['feedback']['class'] = $classfeedback.' feedbacktext';
|
||||
$data['feedback']['content'] = ' ';
|
||||
} else {
|
||||
$data['feedback']['class'] = $class.' feedbacktext';
|
||||
$data['feedback']['class'] = $classfeedback.' feedbacktext';
|
||||
$data['feedback']['content'] = format_text($grade_grade->feedback, $grade_grade->feedbackformat);
|
||||
}
|
||||
}
|
||||
|
@ -33,8 +33,8 @@
|
||||
.user-grade td.item {border-left: 1px solid gray;border-right: 1px solid gray;}
|
||||
.user-grade td.excluded {background-color: #666;}
|
||||
.user-grade td.hidden {color: #aaa;}
|
||||
.user-grade td.feedbacktext {max-width:600px;padding:0;}
|
||||
.user-grade td.feedbacktext {max-width:600px;padding:2px 2px;}
|
||||
.pagelayout-report .user-grade .feedbacktext .no-overflow {overflow:auto;padding:0.25em;}
|
||||
|
||||
table.user-grade td.feedbacktext {text-align:left;width: 40%;font-size: 0.8em;white-space:normal;}
|
||||
table.user-grade td.itemcenter {text-align:center;}
|
||||
table.user-grade td.itemcenter {text-align:center;}
|
||||
|
Loading…
x
Reference in New Issue
Block a user