mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-29 11:46:19 +01:00
Code Issues Projects Releases Wiki Activity

MDL-62351 privacy: check that subsystem/plugintype exist

Browse Source
This commit is contained in:
Marina Glancy 2018-05-09 16:15:55 +08:00
parent 02c7769422
commit 468c8d39c3
4 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
blog/classes/privacy/provider.php
View File

@ -72,7 +72,7 @@ class provider implements
// coursemoduleid, courseid, moduleid, groupid, rating, usermodified.
], 'privacy:metadata:post');
$collection->link_subsystem('core_comments', 'privacy:metadata:core_comments');
$collection->link_subsystem('core_comment', 'privacy:metadata:core_comments');
$collection->link_subsystem('core_files', 'privacy:metadata:core_files');
$collection->link_subsystem('core_tag', 'privacy:metadata:core_tag');

2
competency/classes/privacy/provider.php
View File

@ -211,7 +211,7 @@ class provider implements
], 'privacy:metadata:competency_userevidencecomp');
// Comments can be left on learning plans and competencies.
$collection->link_subsystem('core_comments', 'privacy:metadata:core_comments');
$collection->link_subsystem('core_comment', 'privacy:metadata:core_comments');
return $collection;
}

2
mod/assign/feedback/editpdf/classes/privacy/provider.php
View File

@ -59,7 +59,7 @@ class provider implements metadataprovider, assignfeedback_provider {
];
$collection->add_database_table('assignfeedback_editpdf_quick', $quickdata, 'privacy:metadata:tablepurpose');
$collection->add_subsystem_link('core_files', [], 'privacy:metadata:filepurpose');
$collection->add_subsystem_link('core_fileconverted', [], 'privacy:metadata:conversionpurpose');
$collection->add_subsystem_link('core_fileconverter', [], 'privacy:metadata:conversionpurpose');
return $collection;
}

12
privacy/tests/provider_test.php
View File

@ -128,6 +128,18 @@ class provider_testcase extends advanced_testcase {
$this->assertTrue($DB->get_manager()->table_exists($item->get_name()));
}
if ($item instanceof \core_privacy\local\metadata\types\plugintype_link) {
// Check that plugin type is valid.
$this->assertTrue(array_key_exists($item->get_name(), \core_component::get_plugin_types()));
}
if ($item instanceof subsystem_link) {
// Check that core subsystem exists.
list($plugintype, $pluginname) = \core_component::normalize_component($item->get_name());
$this->assertEquals('core', $plugintype);
$this->assertTrue(\core_component::is_core_subsystem($pluginname));
}
if ($summary = $item->get_summary()) {
// Summary is optional, but when provided must be a valid string identifier.
$this->assertInternalType('string', $summary);