From 4756710889d7c99dc1094e841c967e4aaabf18e4 Mon Sep 17 00:00:00 2001 From: Aaron Barnes <aaron.barnes@totaralms.com> Date: Mon, 22 Aug 2011 14:54:41 +1200 Subject: [PATCH] MDL-28397 completion: Activity completion criteria not showing grading requirement Credit goes to Evan Irving-Pease for the patch --- lib/completion/completion_criteria_activity.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/completion/completion_criteria_activity.php b/lib/completion/completion_criteria_activity.php index 6103731b2e1..096d1572256 100644 --- a/lib/completion/completion_criteria_activity.php +++ b/lib/completion/completion_criteria_activity.php @@ -269,7 +269,7 @@ class completion_criteria_activity extends completion_criteria { $details['requirement'][] = get_string('viewingactivity', 'completion', $this->module); } - if ($module->completiongradeitemnumber) { + if (!is_null($module->completiongradeitemnumber)) { $details['requirement'][] = get_string('achievinggrade', 'completion'); } }