mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-13 12:32:08 +02:00
Code Issues Projects Releases Wiki Activity

MDL-60637 core_group: fix unit tests failures

Browse Source
This commit is contained in:
Simey Lameze 2017-11-14 11:26:33 +08:00
parent effa7d2ba1
commit 486ecb1b89
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
group/tests/externallib_test.php
View File

@ -106,9 +106,8 @@ class core_group_externallib_testcase extends externallib_advanced_testcase {
$froups = core_group_external::create_groups(array($group3));
$this->fail('Exception expected due to already existing idnumber.');
} catch (moodle_exception $e) {
$this->assertInstanceOf('invalid_parameter_exception', $e);
$this->assertEquals('Invalid parameter value detected (Group with the same idnumber already exists)',
$e->getMessage());
$this->assertInstanceOf('moodle_exception', $e);
$this->assertEquals(get_string('idnumbertaken', 'error'), $e->getMessage());
}
// Call without required capability
@ -258,9 +257,8 @@ class core_group_externallib_testcase extends externallib_advanced_testcase {
$groupings = core_group_external::create_groupings(array($grouping1data));
$this->fail('Exception expected due to already existing idnumber.');
} catch (moodle_exception $e) {
$this->assertInstanceOf('invalid_parameter_exception', $e);
$this->assertEquals('Invalid parameter value detected (Grouping with the same idnumber already exists)',
$e->getMessage());
$this->assertInstanceOf('moodle_exception', $e);
$this->assertEquals(get_string('idnumbertaken', 'error'), $e->getMessage());
}
// No exception should be triggered.
@ -285,9 +283,8 @@ class core_group_externallib_testcase extends externallib_advanced_testcase {
$groupings = core_group_external::update_groupings(array($grouping2data));
$this->fail('Exception expected due to already existing idnumber.');
} catch (moodle_exception $e) {
$this->assertInstanceOf('invalid_parameter_exception', $e);
$this->assertEquals('Invalid parameter value detected (A different grouping with the same idnumber already exists)',
$e->getMessage());
$this->assertInstanceOf('moodle_exception', $e);
$this->assertEquals(get_string('idnumbertaken', 'error'), $e->getMessage());
}
}