mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-24 18:04:43 +02:00
Code Issues Projects Releases Wiki Activity

MDL-51415 webservice: Check course access using can_access_course()

Browse Source 
This function check both user enrolled and course:view capabilities
This commit is contained in:
Juan Leyva 2015-09-22 15:29:49 +02:00
parent d230899db8
commit 48a90a215b
3 changed files with 5 additions and 4 deletions

5
group/externallib.php

@ -1363,13 +1363,14 @@ class core_group_external extends external_api {
}
// Validate if the user is enrolled in the course.
if (!is_enrolled($coursecontext, $user->id)) {
$course = get_course($cm->course);
if (!can_access_course($course, $user, '', true)) {
// We return a warning because the function does not fail for not enrolled users.
$warning = array();
$warning['item'] = 'course';
$warning['itemid'] = $cm->course;
$warning['warningcode'] = '1';
$warning['message'] = "User $user->id is not enrolled in course $cm->course";
$warning['message'] = "User $user->id cannot access course $cm->course";
$warnings[] = $warning;
}
}

2
notes/externallib.php

@ -690,7 +690,7 @@ class core_notes_external extends external_api {
throw new moodle_exception('invaliduserid');
}
if ($course->id != SITEID and !is_enrolled($context, $user, '', true)) {
if ($course->id != SITEID and !can_access_course($course, $user, '', true)) {
throw new moodle_exception('notenrolledprofile');
}
}

2
user/externallib.php

@ -1394,7 +1394,7 @@ class core_user_external extends external_api {
profile_view($user, $usercontext);
} else {
// Case like user/view.php.
if (!$currentuser and !is_enrolled($coursecontext, $user->id)) {
if (!$currentuser and !can_access_course($course, $user, '', true)) {
throw new moodle_exception('notenrolledprofile');
}