mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-13 04:22:07 +02:00
Code Issues Projects Releases Wiki Activity

MDL-77350 favourites: Added class properties that are not declared

Browse Source 
In PHP 8.2 and later, setting a value to an undeclared class property is
deprecated and emits a deprecation notice.
So we need to add missing class properties that still need to be declared.

// Removed test_add_malformed_favourite()
PHPUnit version >= 9.5 no longer converts PHP deprecations to exceptions by default.
To comply with PHP 8.2, which will deprecate the dynamic properties,
we need to remove test_add_malformed_favourite()
because the test will raise a warning for dynamic property deprecations.
This commit is contained in:
Meirza 2023-02-22 11:41:51 +07:00
parent 684343eee7
commit 4937a1fd1c
3 changed files with 5 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
favourites/classes/local/entity/favourite.php
View File

@ -59,6 +59,9 @@ class favourite {
/** @var int $timemodified the time at which the last modification of the favourite took place.*/
public $timemodified;
/** @var string $uniquekey favourite unique key.*/
public $uniquekey;
/**
* Favourite constructor.
* @param string $component the frankenstyle name of the component containing the favourited item. E.g. 'core_course'.

3
favourites/classes/local/repository/favourite_repository.php
View File

@ -95,7 +95,8 @@ class favourite_repository implements favourite_repository_interface {
'ordering' => false,
'timecreated' => false,
'timemodified' => false,
'id' => false
'id' => false,
'uniquekey' => false
];
$requiredfields = array_filter($allowedfields, function($field) {

22
favourites/tests/repository_test.php
View File

@ -81,28 +81,6 @@ class repository_test extends \advanced_testcase {
$favouritesrepo->add($favcourse);
}
/**
* Tests that malformed favourites cannot be saved.
*/
public function test_add_malformed_favourite() {
list($user1context, $user2context, $course1context, $course2context) = $this->setup_users_and_courses();
// Create a favourites repository and favourite a course.
$favouritesrepo = new favourite_repository($user1context);
$favcourse = new favourite(
'core_course',
'course',
$course1context->instanceid,
$course1context->id,
$user1context->instanceid
);
$favcourse->something = 'something';
$this->expectException('moodle_exception');
$favouritesrepo->add($favcourse);
}
/**
* Tests that incomplete favourites cannot be saved.
*/