mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-13 12:32:08 +02:00
Code Issues Projects Releases Wiki Activity

MDL-52811 course: fix unit tests broken by setforcedlanguage

Browse Source
This commit is contained in:
Davo Smith 2018-02-01 16:48:14 +00:00
parent 1433a07881
commit 4a9624af21
3 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
admin/tool/uploadcourse/tests/course_test.php
View File

@ -266,6 +266,8 @@ class tool_uploadcourse_course_testcase extends advanced_testcase {
global $DB;
$this->resetAfterTest(true);
cron_setup_user(); // To avoid warnings related to 'moodle/course:setforcedlanguage' capability check.
// Create.
$mode = tool_uploadcourse_processor::MODE_CREATE_NEW;
$updatemode = tool_uploadcourse_processor::UPDATE_NOTHING;

2
backup/moodle2/restore_stepslib.php
View File

@ -1895,7 +1895,7 @@ class restore_course_structure_step extends restore_structure_step {
$data->completionnotify = 0;
}
$languages = get_string_manager()->get_list_of_translations(); // Get languages for quick search
if (!array_key_exists($data->lang, $languages)) {
if (isset($data->lang) && !array_key_exists($data->lang, $languages)) {
$data->lang = '';
}

2
course/tests/externallib_test.php
View File

@ -412,6 +412,7 @@ class core_course_externallib_testcase extends externallib_advanced_testcase {
$contextid = context_system::instance()->id;
$roleid = $this->assignUserCapability('moodle/course:create', $contextid);
$this->assignUserCapability('moodle/course:visibility', $contextid, $roleid);
$this->assignUserCapability('moodle/course:setforcedlanguage', $contextid, $roleid);
$category = self::getDataGenerator()->create_category();
@ -1129,6 +1130,7 @@ class core_course_externallib_testcase extends externallib_advanced_testcase {
$this->assignUserCapability('moodle/course:changesummary', $contextid, $roleid);
$this->assignUserCapability('moodle/course:visibility', $contextid, $roleid);
$this->assignUserCapability('moodle/course:viewhiddencourses', $contextid, $roleid);
$this->assignUserCapability('moodle/course:setforcedlanguage', $contextid, $roleid);
// Create category and course.
$category1 = self::getDataGenerator()->create_category();