mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-20 07:56:06 +02:00
Code Issues Projects Releases Wiki Activity

MDL-59241 mod_workshop: Fix testing found issues

Browse Source 
- totalfilesize counting all submissions
- Improved function documentation
This commit is contained in:
Juan Leyva 2017-10-04 13:09:59 +02:00 committed by Eloy Lafuente (stronk7)
parent 2973f64318
commit 4c2a2bd7ce
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
mod/workshop/classes/external.php
View File

@ -782,7 +782,8 @@ class mod_workshop_external extends external_api {
}
/**
* Retrieves all the workshop submissions visible by the current user or the one done by the given user.
* Retrieves all the workshop submissions visible by the current user or the one done by the given user
* (except example submissions).
*
* @param int $workshopid the workshop instance id
* @param int $userid get submissions done by this user
@ -847,7 +848,7 @@ class mod_workshop_external extends external_api {
$fs = get_file_storage();
$files = $fs->get_area_files($context->id, 'mod_workshop', array('submission_content', 'submission_attachment'));
foreach ($files as $file) {
if ($file->is_directory() || !isset($submissionsrecords[$file->get_itemid()])) {
if ($file->is_directory()) {
continue;
}
$totalfilesize += $file->get_filesize();
@ -874,7 +875,8 @@ class mod_workshop_external extends external_api {
submission_exporter::get_read_structure()
),
'totalcount' => new external_value(PARAM_INT, 'Total count of submissions.'),
'totalfilesize' => new external_value(PARAM_INT, 'Total size (bytes) of the files included in the submissions.'),
'totalfilesize' => new external_value(PARAM_INT, 'Total size (bytes) of the files attached to all the
submissions (even the ones not returned due to pagination).'),
'warnings' => new external_warnings()
)
);

2
mod/workshop/db/services.php
View File

@ -88,7 +88,7 @@ $functions = array(
'mod_workshop_get_submissions' => array(
'classname' => 'mod_workshop_external',
'methodname' => 'get_submissions',
'description' => 'Retrieves all the workshop submissions or the one done by the given user.',
'description' => 'Retrieves all the workshop submissions or the one done by the given user (except example submissions).',
'type' => 'read',
'services' => array(MOODLE_OFFICIAL_MOBILE_SERVICE)
),