mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-14 13:02:07 +02:00
Code Issues Projects Releases Wiki Activity

MDL-78530 core_completion: Remove $CFG->completiondefault setting

Browse Source
This commit is contained in:
Amaia Anabitarte 2023-07-26 18:24:15 +02:00
parent 1f68fe635f
commit 4c4e2224e1
7 changed files with 15 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
admin/settings/subsystems.php
View File

@ -31,8 +31,6 @@ if ($hassiteconfig) { // speedup for non-admins, add all caps used on this page
1 => get_string('completionactivitydefault', 'completion'),
0 => get_string('completion_none', 'completion')
);
$optionalsubsystems->add(new admin_setting_configselect('completiondefault', new lang_string('completiondefault', 'completion'),
new lang_string('configcompletiondefault', 'completion'), 1, $options));
$optionalsubsystems->add($checkbox = new admin_setting_configcheckbox('enableavailability',
new lang_string('enableavailability', 'availability'),

2
completion/classes/form/form_trait.php
View File

@ -103,7 +103,6 @@ trait form_trait {
* @param bool $supportviews True if the module supports views and false otherwise.
* @param bool $supportgrades True if the module supports grades and false otherwise.
* @param bool $rating True if the rating feature is enabled and false otherwise.
* @param bool $defaultcompletion True if the default completion is enabled and false otherwise. To review in MDL-78531.
* @param int|null $courseid Course where to add completion elements.
* @throws \coding_exception If the form is not moodleform_mod and $modname is null.
*/
@ -112,7 +111,6 @@ trait form_trait {
bool $supportviews = false,
bool $supportgrades = false,
bool $rating = false,
bool $defaultcompletion = true,
?int $courseid = null
): void {
global $SITE;

1
completion/upgrade.txt
View File

@ -13,6 +13,7 @@ information provided here is intended especially for developers.
through the form and the current form that has been sent.
* Support for deprecated `[modname]_get_completion_state` callbacks has been removed, custom completion rules must be implemented
by appropriate `mod_[modname]\completion\custom_completion` class instead
* $CFG->completiondefault setting has been removed.
=== 4.0 ===
* New method mark_course_completions_activity_criteria() has been added to mark course completions instantly. It is

6
lang/en/completion.php
View File

@ -88,7 +88,6 @@ $string['completion_link'] = 'activity/completion';
$string['completion_manual'] = 'Students can manually mark the activity as completed';
$string['completion_none'] = 'Do not indicate activity completion';
$string['completionactivitydefault'] = 'Use activity default';
$string['completiondefault'] = 'Default completion tracking';
$string['completiondisabled'] = 'Disabled, not shown in activity settings';
$string['completionenabled'] = 'Enabled, control via completion and activity settings';
$string['completionexpected'] = 'Set reminder in Timeline';
@ -118,7 +117,6 @@ $string['completionusegrade_help'] = 'If enabled, the activity is considered com
$string['completionupdated'] = 'Updated completion for activity <b>{$a}</b>';
$string['completionview'] = 'Require view';
$string['completionview_desc'] = 'Student must view this activity to complete it';
$string['configcompletiondefault'] = 'The default setting for completion tracking when creating new activities.';
$string['configenablecompletion'] = 'If enabled, course and activity completion conditions may be set. Setting activity completion conditions is recommended so that meaningful data is displayed for users in their course overview on the Dashboard.';
$string['confirmselfcompletion'] = 'Confirm self completion';
$string['courseaggregation'] = 'Condition requires';
@ -260,4 +258,8 @@ $string['youmust'] = 'You must';
// Deprecated since Moodle 4.0.
$string['yourprogress'] = 'Your progress';
// Deprecated since Moodle 4.3.
$string['editcoursecompletionsettings'] = 'Edit course completion settings';
$string['completiondefault'] = 'Default completion tracking';
$string['configcompletiondefault'] = 'The default setting for completion tracking when creating new activities.';

2
lang/en/deprecated.txt
View File

@ -92,3 +92,5 @@ devicedetectregexexpression,core_admin
devicedetectregexvalue,core_admin
modshowcmtitle,core
makeavailablecmtitle,core
completiondefault,core_completion
configcompletiondefault,core_completion

7
lib/db/upgrade.php
View File

@ -3501,5 +3501,12 @@ privatefiles,moodle|/user/files.php';
upgrade_main_savepoint(true, 2023082200.04);
}
if ($oldversion < 2023082600.01) {
unset_config('completiondefault');
// Main savepoint reached.
upgrade_main_savepoint(true, 2023082600.01);
}
return true;
}

2
version.php
View File

@ -29,7 +29,7 @@
defined('MOODLE_INTERNAL') || die();
$version = 2023082600.00; // YYYYMMDD = weekly release date of this DEV branch.
$version = 2023082600.01; // YYYYMMDD = weekly release date of this DEV branch.
// RR = release increments - 00 in DEV branches.
// .XX = incremental changes.
$release = '4.3dev+ (Build: 20230826)'; // Human-friendly version name