MDL-77164 privacy: typehint test content writer

This commit is contained in:
Marina Glancy 2023-02-28 13:42:50 +00:00
parent fcf887919b
commit 4d765cd699
27 changed files with 62 additions and 4 deletions

View File

@ -53,6 +53,7 @@ class provider_test extends provider_testcase {
$showadvanced = 1;
set_user_preference('definerole_showadvanced', $showadvanced);
provider::export_user_preferences($user->id);
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context(\context_system::instance());
$prefs = $writer->get_user_preferences('core_role');
$this->assertEquals(transform::yesno($showadvanced), transform::yesno($prefs->definerole_showadvanced->value));
@ -184,6 +185,7 @@ class provider_test extends provider_testcase {
// Retrieve role capabilities and role assignments.
provider::export_user_data($approvedcontextlist);
foreach ($contextlist as $context) {
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertTrue($writer->has_any_data());
if ($context->contextlevel == CONTEXT_MODULE) {
@ -413,6 +415,7 @@ class provider_test extends provider_testcase {
];
// Test User is assigned role teacher to cohort.
provider::export_user_role_to_cohort($user->id);
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($contextuserassignover);
$this->assertTrue($writer->has_any_data());
$exported = (array)$writer->get_related_data($subcontextteacher, 'cohortroles');
@ -430,6 +433,7 @@ class provider_test extends provider_testcase {
api::create_cohort_role_assignment($params);
api::sync_all_cohort_roles();
provider::export_user_role_to_cohort($user->id);
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($contextuser);
$this->assertTrue($writer->has_any_data());
$exported = (array)$writer->get_related_data($subcontextteacher, 'cohortroles');

View File

@ -111,6 +111,7 @@ class provider_test extends \core_privacy\tests\provider_testcase {
$key = $DB->get_record('user_private_key', ['value' => $keyvalue]);
// Validate exported data.
$this->setUser($user);
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertFalse($writer->has_any_data());
$this->export_context_data_for_user($user->id, $context, 'tool_mobile');

View File

@ -106,6 +106,7 @@ class provider_test extends provider_testcase {
$usercontext = \context_user::instance($user->id);
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($usercontext);
$this->assertFalse($writer->has_any_data());
$approvedlist = new approved_contextlist($user, 'auth_mnet', [$usercontext->id]);

View File

@ -185,6 +185,7 @@ class provider_test extends \core_privacy\tests\provider_testcase {
// Export the data.
$this->export_context_data_for_user($user->id, $context, 'block_html');
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = \core_privacy\local\request\writer::with_context($context);
$this->assertTrue($writer->has_any_data());
@ -233,6 +234,7 @@ class provider_test extends \core_privacy\tests\provider_testcase {
// Export the data.
$this->export_context_data_for_user($user->id, $context, 'block_html');
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = \core_privacy\local\request\writer::with_context($context);
$this->assertFalse($writer->has_any_data());
}

View File

@ -180,6 +180,7 @@ class provider_test extends provider_testcase {
provider::export_user_data($approvedcontextlist);
foreach ($contextlist as $context) {
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertTrue($writer->has_any_data());

View File

@ -114,6 +114,7 @@ class provider_test extends \core_privacy\tests\provider_testcase {
$approvedcontextlist = new approved_contextlist($user1, 'enrol_cohort', $contextlist->get_contextids());
provider::export_user_data($approvedcontextlist);
foreach ($contextlist as $context) {
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$data = $writer->get_data([
get_string('pluginname', 'enrol_cohort'),

View File

@ -103,6 +103,7 @@ class provider_test extends \core_privacy\tests\provider_testcase {
$approvedcontextlist = new approved_contextlist($user1, 'enrol_meta', $contextlist->get_contextids());
provider::export_user_data($approvedcontextlist);
foreach ($contextlist as $context) {
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$data = $writer->get_data([
get_string('pluginname', 'enrol_meta'),

View File

@ -67,6 +67,7 @@ class provider_test extends provider_testcase {
// Validate exported data.
provider::export_user_preferences($user->id);
$context = \context_user::instance($user->id);
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertTrue($writer->has_any_data());
$prefs = $writer->get_user_preferences('gradingform_guide');

View File

@ -110,6 +110,7 @@ class provider_test extends provider_testcase {
$this->setUser($user);
$context = \context_system::instance();
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertFalse($writer->has_any_data());
$this->export_context_data_for_user($user->id, $context, 'core_grading');

View File

@ -77,6 +77,7 @@ class provider_test extends \core_privacy\tests\provider_testcase {
// Validate exported data for our test user.
provider::export_user_preferences($user->id);
$context = \context_user::instance($user->id);
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertTrue($writer->has_any_data());
$prefs = $writer->get_user_preferences('gradereport_grader');
@ -99,6 +100,7 @@ class provider_test extends \core_privacy\tests\provider_testcase {
// Validate exported data.
provider::export_user_preferences($user->id);
$context = \context_user::instance($user->id);
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertTrue($writer->has_any_data());
$prefs = $writer->get_user_preferences('gradereport_grader');

View File

@ -67,6 +67,7 @@ class provider_test extends \core_privacy\tests\provider_testcase {
// Validate exported data.
provider::export_user_preferences($user->id);
$context = \context_user::instance($user->id);
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertTrue($writer->has_any_data());
$prefs = $writer->get_user_preferences('gradereport_user');

View File

@ -90,6 +90,7 @@ class provider_test extends provider_testcase {
// Retrieve groups for user1.
$this->setUser($user1);
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
provider::export_groups($context, '');
@ -134,6 +135,7 @@ class provider_test extends provider_testcase {
// Retrieve groups for user1.
$this->setUser($user1);
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
provider::export_groups($context, 'enrol_self');
@ -792,6 +794,7 @@ class provider_test extends provider_testcase {
// Export all of the data for the context.
$this->export_context_data_for_user($user1->id, $context, 'core_group');
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertTrue($writer->has_any_data());

View File

@ -118,6 +118,7 @@ class provider_test extends \core_privacy\tests\provider_testcase {
// Export the data for the system context.
// There should be two.
$this->export_context_data_for_user($user->id, $systemcontext, 'editor_atto');
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = \core_privacy\local\request\writer::with_context($systemcontext);
$this->assertTrue($writer->has_any_data());
@ -535,6 +536,7 @@ class provider_test extends \core_privacy\tests\provider_testcase {
// Should have the data.
$this->export_context_data_for_user($user->id, $usercontext, 'editor_atto');
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = \core_privacy\local\request\writer::with_context($usercontext);
$this->assertTrue($writer->has_any_data());
@ -587,6 +589,7 @@ class provider_test extends \core_privacy\tests\provider_testcase {
// Should have the data.
$this->export_context_data_for_user($user->id, $otherusercontext, 'editor_atto');
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = \core_privacy\local\request\writer::with_context($otherusercontext);
$this->assertTrue($writer->has_any_data());

View File

@ -47,7 +47,9 @@ class provider_test extends \core_privacy\tests\provider_testcase {
$this->setAdminUser();
provider::export_user_preferences($USER->id);
$this->assertFalse(writer::with_context(\context_system::instance())->has_any_data());
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context(\context_system::instance());
$this->assertFalse($writer->has_any_data());
}
/**
@ -67,7 +69,9 @@ class provider_test extends \core_privacy\tests\provider_testcase {
// Export test users preferences.
provider::export_user_preferences($user->id);
$this->assertFalse(writer::with_context(\context_system::instance())->has_any_data());
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context(\context_system::instance());
$this->assertFalse($writer->has_any_data());
}
/**
@ -87,9 +91,11 @@ class provider_test extends \core_privacy\tests\provider_testcase {
// Export test users preferences.
provider::export_user_preferences($user->id);
$this->assertTrue(writer::with_context(\context_system::instance())->has_any_data());
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context(\context_system::instance());
$this->assertTrue($writer->has_any_data());
$prefs = writer::with_context(\context_system::instance())->get_user_preferences('core_editor');
$prefs = $writer->get_user_preferences('core_editor');
$this->assertNotEmpty($prefs->htmleditor);
$this->assertNotEmpty($prefs->htmleditor->value);
$this->assertNotEmpty($prefs->htmleditor->description);

View File

@ -70,6 +70,7 @@ class provider_test extends provider_testcase {
provider::export_userkeys($context, $subcontext, 'core_tests');
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertTrue($writer->has_any_data());
@ -107,6 +108,7 @@ class provider_test extends provider_testcase {
// Export all keys in core_tests.
provider::export_userkeys($context, $subcontext, 'core_tests');
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertTrue($writer->has_any_data());
@ -143,6 +145,7 @@ class provider_test extends provider_testcase {
provider::export_userkeys($context, $subcontext, 'core_tests');
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertTrue($writer->has_any_data());
@ -179,11 +182,13 @@ class provider_test extends provider_testcase {
// Export all keys in core_tests against instance 43 - no keys.
provider::export_userkeys($context, $subcontext, 'core_tests', 43);
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertFalse($writer->has_any_data());
// Export all keys in core_tests against instance 42.
provider::export_userkeys($context, $subcontext, 'core_tests', 42);
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertTrue($writer->has_any_data());
$exported = $writer->get_related_data($subcontext, 'userkeys');
@ -224,11 +229,13 @@ class provider_test extends provider_testcase {
// Export all keys in core_tests against instance 43 - no keys.
provider::export_userkeys($context, $subcontext, 'core_tests', 43);
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertFalse($writer->has_any_data());
// Export all keys in core_tests against instance 42.
provider::export_userkeys($context, $subcontext, 'core_tests', 42);
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertTrue($writer->has_any_data());
$exported = $writer->get_related_data($subcontext, 'userkeys');
@ -278,11 +285,13 @@ class provider_test extends provider_testcase {
// Export all keys in core_tests against instance 43 - no keys.
provider::export_userkeys($context, $subcontext, 'core_tests', 43);
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertFalse($writer->has_any_data());
// Export all keys in core_tests against instance 42.
provider::export_userkeys($context, $subcontext, 'core_tests', 42);
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertTrue($writer->has_any_data());
$exported = $writer->get_related_data($subcontext, 'userkeys');

View File

@ -299,6 +299,7 @@ class provider_test extends provider_testcase {
// Give the submission a grade.
$assign->save_grade($user->id, $data);
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertFalse($writer->has_any_data());
@ -411,6 +412,7 @@ class provider_test extends provider_testcase {
$flagdata->extensionduedate = $duedate;
$assign->update_user_flags($flagdata);
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertFalse($writer->has_any_data());

View File

@ -119,6 +119,7 @@ class provider_test extends provider_testcase {
);
writer::reset();
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertFalse($writer->has_any_data());
provider::export_user_data($approvedcontextlist);

View File

@ -170,6 +170,7 @@ class provider_test extends \core_privacy\tests\provider_testcase {
provider::export_user_data($approvedcontextlist);
// Ensure that the quiz data was exported correctly.
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertTrue($writer->has_any_data());
@ -366,6 +367,7 @@ class provider_test extends \core_privacy\tests\provider_testcase {
provider::export_user_data($approvedcontextlist);
// Ensure that nothing was exported.
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertFalse($writer->has_any_data_in_any_context());

View File

@ -68,6 +68,7 @@ class provider_test extends \core_privacy\tests\provider_testcase {
// Validate exported data.
provider::export_user_preferences($user->id);
$context = \context_user::instance($user->id);
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertTrue($writer->has_any_data());
$prefs = $writer->get_user_preferences('scormreport_basic');

View File

@ -71,6 +71,7 @@ class provider_test extends \core_privacy\tests\provider_testcase {
// Validate exported data.
provider::export_user_preferences($user->id);
$context = \context_user::instance($user->id);
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertTrue($writer->has_any_data());
$prefs = $writer->get_user_preferences('scormreport_interactions');

View File

@ -68,6 +68,7 @@ class provider_test extends \core_privacy\tests\provider_testcase {
// Validate exported data.
provider::export_user_preferences($user->id);
$context = \context_user::instance($user->id);
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertTrue($writer->has_any_data());
$prefs = $writer->get_user_preferences('scormreport_objectives');

View File

@ -229,6 +229,7 @@ class provider_test extends \core_privacy\tests\provider_testcase {
foreach ($contextlist as $context) {
$this->assertEquals(CONTEXT_COURSE, $context->contextlevel);
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertTrue($writer->has_any_data());
}

View File

@ -96,6 +96,7 @@ class provider_test extends \core_privacy\tests\provider_testcase {
$options = new \question_display_options();
provider::export_question_usage($testuser->id, $context, [], $quba->get_id(), $options, false);
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertFalse($writer->has_any_data_in_any_context());
@ -137,6 +138,7 @@ class provider_test extends \core_privacy\tests\provider_testcase {
// Export all questions for this attempt.
$options = new \question_display_options();
provider::export_question_usage($testuser->id, $context, [], $quba->get_id(), $options, true);
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertTrue($writer->has_any_data_in_any_context());
@ -161,6 +163,7 @@ class provider_test extends \core_privacy\tests\provider_testcase {
$options->marks = \question_display_options::HIDDEN;
provider::export_question_usage($testuser->id, $context, [], $quba->get_id(), $options, true);
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertTrue($writer->has_any_data_in_any_context());

View File

@ -93,6 +93,7 @@ trait core_question_privacy_helper {
[get_string('questions', 'core_question')]
);
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
foreach ($quba->get_slots() as $slotno) {

View File

@ -283,6 +283,7 @@ class provider_test extends \core_privacy\tests\provider_testcase {
$subcontext = [];
provider::export_area_ratings($u1->id, $context, $subcontext, 'core_course', 'course', $course1->id, true);
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertTrue($writer->has_any_data());
$rating = $writer->get_related_data($subcontext, 'rating');
@ -293,6 +294,7 @@ class provider_test extends \core_privacy\tests\provider_testcase {
$subcontext = ['foo'];
provider::export_area_ratings($u1->id, $context, $subcontext, 'core_course', 'course', $course2->id, true);
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertTrue($writer->has_any_data());
$result = $writer->get_related_data($subcontext, 'rating');
@ -304,6 +306,7 @@ class provider_test extends \core_privacy\tests\provider_testcase {
$subcontext = ['foo'];
provider::export_area_ratings($u1->id, $context, $subcontext, 'core_course', 'course', $course3->id, true);
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertTrue($writer->has_any_data());
$result = $writer->get_related_data($subcontext, 'rating');
@ -315,6 +318,7 @@ class provider_test extends \core_privacy\tests\provider_testcase {
$subcontext = ['foo', 'files'];
provider::export_area_ratings($u1->id, $context, $subcontext, 'core_course', 'files', $course3->id, true);
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertTrue($writer->has_any_data());
$result = $writer->get_related_data($subcontext, 'rating');
@ -327,6 +331,7 @@ class provider_test extends \core_privacy\tests\provider_testcase {
$subcontext = ['user'];
provider::export_area_ratings($u3->id, $context, $subcontext, 'user', 'user', $u3->id, false);
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertTrue($writer->has_any_data());
$result = $writer->get_related_data($subcontext, 'rating');

View File

@ -72,6 +72,7 @@ class provider_test extends provider_testcase {
// Validate exported data.
$this->setUser($user);
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertFalse($writer->has_any_data());
$this->export_context_data_for_user($user->id, $context, 'core_rss');

View File

@ -77,6 +77,7 @@ class provider_test extends provider_testcase {
// Retrieve tags only for this user.
provider::export_item_tags($user->id, $context, $subcontext, 'core_course', 'course', $course->id, true);
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$this->assertTrue($writer->has_any_data());
@ -261,6 +262,7 @@ class provider_test extends provider_testcase {
}, \core_tag_tag::get_by_name_bulk(\core_tag_collection::get_default(), ['Birdwatching', 'Computers'])));
provider::export_user_data(new \core_privacy\local\request\approved_contextlist($user1, 'core_tag', [$context->id]));
/** @var \core_privacy\tests\request\content_writer $writer */
$writer = writer::with_context($context);
$data = $writer->get_data(['Tags', $tagids[0]]);