MDL-35823 - Accessibility - Converted the help popup header from H1 to H2 to improve the over all DOM

This commit is contained in:
Jason Fowler 2013-01-30 09:07:43 +08:00
parent 1918a2452e
commit 4df8223cbe
3 changed files with 10 additions and 3 deletions

View File

@ -67,7 +67,13 @@ if ($sm->string_exists($identifier.'_help', $component)) {
$options->newlines = false;
$options->overflowdiv = !$ajax;
echo $OUTPUT->heading(format_string(get_string($identifier, $component)), 1, 'helpheading');
if ($ajax) {
// When using AJAX, the header should be H2 as it is in the same DOM as the calling page.
echo $OUTPUT->heading(format_string(get_string($identifier, $component)), 2, 'helpheading');
} else {
// When not using AJAX, the header should be H1 as it is in it's own window.
echo $OUTPUT->heading(format_string(get_string($identifier, $component)), 1, 'helpheading');
}
// Should be simple wiki only MDL-21695
echo format_text(get_string($identifier.'_help', $component), FORMAT_MARKDOWN, $options);

View File

@ -494,7 +494,7 @@ div.yui3-widget-bd {
background: none;
}
div.yui3-widget-bd h1.helpheading {
div.yui3-widget-bd h2.helpheading {
font-size: 16px !important;
font-weight: 800;
margin-top: 5px;

View File

@ -33,7 +33,8 @@ ul {
color:inherit;
font-size:inherit;
}
h1.helpheading {
h1.helpheading,
h2.helpheading {
font-size: 1.6em;
}
/*extra line abve labels and remove padding right for no icon */