mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-03-14 12:40:01 +01:00
Code Issues Projects Releases Wiki Activity

listlib: off-by-one error. I found this while preparing my Brisbane MoodleMoot demo. It was causing notices on the question bank page, or something like that.

Browse Source
This commit is contained in:
tjhunt 2008-10-23 09:04:52 +00:00
parent 865607b319
commit 4f8190a59f
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/listlib.php
View File

@ -210,14 +210,14 @@ class moodle_list{
* @return integer $offset + how many toplevel items where there in this list.
*
*/
function list_from_records($paged = false, $offset =1){
function list_from_records($paged = false, $offset = 1){
$this->paged = $paged;
$this->offset = $offset;
$this->get_records();
$records = $this->records;
$page = $this->page;
if (!empty($page)) {
$this->firstitem = ($page-1) * $this->itemsperpage + 1;
$this->firstitem = ($page - 1) * $this->itemsperpage;
$this->lastitem = $this->firstitem + $this->itemsperpage - 1;
}
$itemiter = $offset;
@ -420,13 +420,13 @@ class moodle_list{
$this->move_item_right($right);
} else if (!empty($moveup)) {
$this->move_item_up_down('up', $moveup);
if ($moveup == $this->items[$this->firstitem -1]->id){//redirect to page that item has been moved to.
if ($moveup == $this->items[$this->firstitem - 1]->id){//redirect to page that item has been moved to.
$this->page --;
$this->pageurl->params(array($this->pageparamname => $this->page));
}
} else if (!empty($movedown)) {
$this->move_item_up_down('down', $movedown);
if ($movedown == $this->items[$this->lastitem -1]->id){//redirect to page that item has been moved to.
if ($movedown == $this->items[$this->lastitem - 1]->id){//redirect to page that item has been moved to.
$this->page ++;
$this->pageurl->params(array($this->pageparamname => $this->page));
}