From 5165c9f46067255029a9ba45aad0e6d4e5aa68b5 Mon Sep 17 00:00:00 2001 From: "Eloy Lafuente (stronk7)" Date: Mon, 31 Oct 2016 19:42:38 +0100 Subject: [PATCH] MDL-56297 forms: Normalize uses of 'url' fields to use size=60 While this is not related to this issue, when reviewing it was detected that the size of those url fields was really small and looking decided to add this bit of normalization over existing uses. --- admin/tool/lp/classes/form/user_evidence.php | 2 +- blog/external_blog_edit_form.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/admin/tool/lp/classes/form/user_evidence.php b/admin/tool/lp/classes/form/user_evidence.php index 28de24cb2cd..74bb0c8337f 100644 --- a/admin/tool/lp/classes/form/user_evidence.php +++ b/admin/tool/lp/classes/form/user_evidence.php @@ -56,7 +56,7 @@ class user_evidence extends persistent { $mform->addElement('editor', 'description', get_string('userevidencedescription', 'tool_lp'), array('rows' => 10)); $mform->setType('description', PARAM_RAW); - $mform->addElement('url', 'url', get_string('userevidenceurl', 'tool_lp'), array(), array('usefilepicker' => false)); + $mform->addElement('url', 'url', get_string('userevidenceurl', 'tool_lp'), array('size' => '60'), array('usefilepicker' => false)); $mform->setType('url', PARAM_RAW_TRIMMED); // Can not use PARAM_URL, it silently converts bad URLs to ''. $mform->addHelpButton('url', 'userevidenceurl', 'tool_lp'); diff --git a/blog/external_blog_edit_form.php b/blog/external_blog_edit_form.php index 9c1208789c5..2e0dcb7cefc 100644 --- a/blog/external_blog_edit_form.php +++ b/blog/external_blog_edit_form.php @@ -36,7 +36,7 @@ class blog_edit_external_form extends moodleform { $mform =& $this->_form; - $mform->addElement('url', 'url', get_string('url', 'blog'), array('size' => 50), array('usefilepicker' => false)); + $mform->addElement('url', 'url', get_string('url', 'blog'), array('size' => 60), array('usefilepicker' => false)); $mform->setType('url', PARAM_URL); $mform->addRule('url', get_string('emptyurl', 'blog'), 'required', null, 'client'); $mform->addHelpButton('url', 'url', 'blog');