diff --git a/admin/settings/security.php b/admin/settings/security.php index 72fac4a77d9..a703f9e0155 100644 --- a/admin/settings/security.php +++ b/admin/settings/security.php @@ -145,7 +145,7 @@ if ($hassiteconfig) { // speedup for non-admins, add all caps used on this page $temp->add(new admin_setting_heading('adminpresets', new lang_string('siteadminpresetspluginname', 'core_adminpresets'), '')); $sensiblesettingsdefault = 'recaptchapublickey@@none, recaptchaprivatekey@@none, googlemapkey3@@none, '; $sensiblesettingsdefault .= 'secretphrase@@url, cronremotepassword@@none, smtpuser@@none, '; - $sensiblesettingsdefault .= 'smtppass@none, proxypassword@@none, quizpassword@@quiz, allowedip@@none, blockedip@@none, '; + $sensiblesettingsdefault .= 'smtppass@@none, proxypassword@@none, quizpassword@@quiz, allowedip@@none, blockedip@@none, '; $sensiblesettingsdefault .= 'dbpass@@logstore_database, messageinbound_hostpass@@none, '; $sensiblesettingsdefault .= 'bind_pw@@auth_cas, pass@@auth_db, bind_pw@@auth_ldap, '; $sensiblesettingsdefault .= 'dbpass@@enrol_database, bind_pw@@enrol_ldap, '; diff --git a/lib/db/upgrade.php b/lib/db/upgrade.php index 38767ba12b8..4525558f9f7 100644 --- a/lib/db/upgrade.php +++ b/lib/db/upgrade.php @@ -3086,5 +3086,18 @@ privatefiles,moodle|/user/files.php'; upgrade_main_savepoint(true, 2022112804.09); } + if ($oldversion < 2022112805.03) { + + // The previous default configuration had a typo, check for its presence and correct if necessary. + $sensiblesettings = get_config('adminpresets', 'sensiblesettings'); + if (strpos($sensiblesettings, 'smtppass@none') !== false) { + $newsensiblesettings = str_replace('smtppass@none', 'smtppass@@none', $sensiblesettings); + set_config('sensiblesettings', $newsensiblesettings, 'adminpresets'); + } + + // Main savepoint reached. + upgrade_main_savepoint(true, 2022112805.03); + } + return true; }