mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-18 05:58:34 +01:00
Code Issues Projects Releases Wiki Activity

MDL-78169 core: Immediate deprecation of htmllize_file_tree

Browse Source 
This should have been done back in 2010 as part of MDL-22950. It has not
been called in that time, and is entirely untested and untestable.
This commit is contained in:
Andrew Nicols 2023-05-09 14:27:55 +08:00
parent 063ffc8073
commit 53577b678c
No known key found for this signature in database
GPG Key ID: 6D1E3157C8CFBF14
2 changed files with 6 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
lib/outputrenderers.php
View File

@ -2732,26 +2732,10 @@ class core_renderer extends renderer_base {
}
/**
* Internal implementation of file tree viewer items rendering.
*
* @param array $dir
* @return string
* @deprecated since Moodle 4.3
*/
public function htmllize_file_tree($dir) {
if (empty($dir['subdirs']) and empty($dir['files'])) {
return '';
}
$result = '<ul>';
foreach ($dir['subdirs'] as $subdir) {
$result .= '<li>'.s($subdir['dirname']).' '.$this->htmllize_file_tree($subdir).'</li>';
}
foreach ($dir['files'] as $file) {
$filename = $file->get_filename();
$result .= '<li><span>'.html_writer::link($file->fileurl, $filename).'</span></li>';
}
$result .= '</ul>';
return $result;
public function htmllize_file_tree() {
throw new coding_exception('This function is deprecated and no longer relevant.');
}
/**
@ -5581,17 +5565,6 @@ class core_renderer_maintenance extends core_renderer {
return '';
}
/**
* Does nothing. The maintenance renderer cannot produce and HTML file tree.
*
* @param array $dir
* @return string
*/
public function htmllize_file_tree($dir) {
return '';
}
/**
* Overridden confirm message for upgrades.
*

3
theme/upgrade.txt
View File

@ -1,6 +1,9 @@
This files describes API changes in /theme/* themes,
information provided here is intended especially for theme designer.
=== 4.3 ===
* The core_renderer::htmllize_file_tree method has been deprecated. This was missed before Moodle 2.0.
=== 4.2 ===
* The moodle-core-popuphelp YUI modal has been removed. It has not been actively used in Moodle since 3.3. It should be replaced with appropriate ESM/AMD JavaScript.
* The moodle-core-tooltip YUI modal has been removed. It should be replaced with appropriate ESM/AMD JavaScript.