mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-18 22:08:20 +01:00
Code Issues Projects Releases Wiki Activity

MDL-81556 tiny_media: Remove unnecessary labels

Browse Source 
* Remove usage of label tags that are not associated with any
 form elements.
* Remove setting of title for the label tags. This is not necessary
as the title text is the same as the text showed in the label.
This commit is contained in:
Jun Pataleta 2024-04-16 15:35:46 +08:00
parent 8cf14f6e70
commit 548796db50
No known key found for this signature in database
GPG Key ID: F83510526D99E2C7
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/editor/tiny/plugins/media/templates/insert_image_modal_details_footer.mustache
View File

@ -29,7 +29,7 @@
<!-- First Column -->
<div class="col-md-6 d-flex align-items-center p-0">
<!-- Row 1: URL related label -->
<label title="{{#str}} filename, tiny_media {{/str}}" class="tiny_image_filename text-truncate mr-1">{{#str}} filename, tiny_media {{/str}}</label>
<span class="tiny_image_filename text-truncate mr-1"></span>
</div>
<!-- Column 2: Saving, canceling, browsing repositories buttons -->
<div class="col-md-6 text-right mt-2 md-0 p-0">

5
lib/editor/tiny/plugins/media/templates/insert_image_modal_insert_footer.mustache
View File

@ -33,12 +33,11 @@
<div class="col-md-6 d-flex align-items-center p-0">
<!-- Row 1: URL related label -->
{{#showdropzone}}
<label for="{{elementid}}_tiny_image_urlentry" title="{{#str}} enterurlor, tiny_media {{/str}}" class="tiny_image_url_label mr-1">{{#str}} enterurlor, tiny_media {{/str}}</label>
<label for="{{elementid}}_tiny_image_urlentry" class="tiny_image_url_label mr-1">{{#str}} enterurlor, tiny_media {{/str}}</label>
{{/showdropzone}}
{{^showdropzone}}
<label for="{{elementid}}_tiny_image_urlentry" title="{{#str}} enterurl, tiny_media {{/str}}" class="tiny_image_url_label mr-1">{{#str}} enterurl, tiny_media {{/str}}</label>
<label for="{{elementid}}_tiny_image_urlentry" class="tiny_image_url_label mr-1">{{#str}} enterurl, tiny_media {{/str}}</label>
{{/showdropzone}}
<label title="{{#str}} filename, tiny_media {{/str}}" class="d-none tiny_image_filename text-truncate mr-1">{{#str}} filename, tiny_media {{/str}}</label>
<!-- Row 2: URL entry input. Needed by the insert image step and image details step if the image URL source from external -->
<input name="urlentry" class="tiny_image_urlentry form-control w-50 mr-1" type="url" id="{{elementid}}_tiny_image_urlentry" size="32" value="{{src}}">
<!-- Row 3: Add button. Needed by the insert image step -->