mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-21 00:12:56 +02:00
Code Issues Projects Releases Wiki Activity

MDL-69106 assignfeedback_editpdf: Keep files in conversion queue

Browse Source 
In some circumstances, a submission waiting to be converted needs to persist
in the conversion queue so that it can be polled on subsequent cron runs.
This commit is contained in:
Cameron Ball 2020-06-30 10:12:33 +08:00
parent c11e2517a7
commit 548c44c89c
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
mod/assign/feedback/editpdf/classes/task/convert_submissions.php
View File

@ -98,6 +98,7 @@ class convert_submissions extends scheduled_task {
}
mtrace('Convert ' . count($users) . ' submission attempt(s) for assignment ' . $assignmentid);
$conversionrequirespolling = false;
foreach ($users as $userid) {
try {
@ -107,6 +108,7 @@ class convert_submissions extends scheduled_task {
case combined_document::STATUS_READY_PARTIAL:
case combined_document::STATUS_PENDING_INPUT:
// The document has not been converted yet or is somehow still ready.
$conversionrequirespolling = true;
continue 2;
}
document_services::get_page_images_for_attempt(
@ -127,7 +129,9 @@ class convert_submissions extends scheduled_task {
}
// Remove from queue.
$DB->delete_records('assignfeedback_editpdf_queue', array('id' => $record->id));
if (!$conversionrequirespolling) {
$DB->delete_records('assignfeedback_editpdf_queue', array('id' => $record->id));
}
}
}