mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-13 20:42:22 +02:00
Code Issues Projects Releases Wiki Activity

MDL-67155 quiz: first attempt_step should record the student's userid

Browse Source
This commit is contained in:
Tim Hunt 2019-11-06 22:17:23 +00:00
parent 01aa126848
commit 550599e001
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mod/quiz/locallib.php
View File

@ -253,7 +253,7 @@ function quiz_start_new_attempt($quizobj, $quba, $attempt, $attemptnumber, $time
$forcedvariantsbyseed, $variantstrategy);
}
$quba->start_all_questions($variantstrategy, $timenow);
$quba->start_all_questions($variantstrategy, $timenow, $attempt->userid);
// Work out the attempt layout.
$sections = $quizobj->get_sections();

7
mod/quiz/tests/attempt_test.php
View File

@ -355,6 +355,7 @@ class mod_quiz_attempt_testcase extends advanced_testcase {
$attempt = quiz_prepare_and_start_new_attempt($quizobj, 2, null, false, [], [], $student1->id);
$this->assertEquals($student1->id, $attempt->userid);
$this->assertEquals(0, $attempt->preview);
$student1attempt = $attempt; // Save for extra verification below.
// Create attempt for student2.
$attempt = quiz_prepare_and_start_new_attempt($quizobj, 2, null, false, [], [], $student2->id);
$this->assertEquals($student2->id, $attempt->userid);
@ -363,5 +364,11 @@ class mod_quiz_attempt_testcase extends advanced_testcase {
$attempt = quiz_prepare_and_start_new_attempt($quizobj, 2, null, false, [], [], $USER->id);
$this->assertEquals($USER->id, $attempt->userid);
$this->assertEquals(1, $attempt->preview);
// Check that the userid stored in the first step is the user the attempt is for,
// not the user who triggered the creation.
$quba = question_engine::load_questions_usage_by_activity($student1attempt->uniqueid);
$step = $quba->get_question_attempt(1)->get_step(0);
$this->assertEquals($student1->id, $step->get_user_id());
}
}