mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-13 12:32:08 +02:00
Code Issues Projects Releases Wiki Activity

"MDL-14129, fix print_error"

Browse Source
This commit is contained in:
dongsheng 2008-06-10 06:27:38 +00:00
parent 282fd2b21a
commit 550f965438
12 changed files with 62 additions and 62 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
mod/quiz/attempt.php
View File

@ -28,23 +28,23 @@
if ($id) {
if (! $cm = get_coursemodule_from_id('quiz', $id)) {
print_error("There is no coursemodule with id $id");
print_error('invalidcoursemodule');
}
if (! $course = $DB->get_record('course', array('id' => $cm->course))) {
print_error("Course is misconfigured");
print_error("coursemisconf");
}
if (! $quiz = $DB->get_record('quiz', array('id' => $cm->instance))) {
print_error("The quiz with id $cm->instance corresponding to this coursemodule $id is missing");
print_error('invalidcoursemodule');
}
} else {
if (! $quiz = $DB->get_record('quiz', array('id' => $q))) {
print_error("There is no quiz with id $q");
print_error('invalidcoursemodule');
}
if (! $course = $DB->get_record('course', array('id' => $quiz->course))) {
print_error("The course with id $quiz->course that the quiz with id $q belongs to is missing");
print_error('invalidcourseid');
}
if (! $cm = get_coursemodule_from_instance("quiz", $quiz->id, $course->id)) {
print_error("The course module for the quiz with id $q is missing");
print_error('invalidcoursemodule');
}
}
@ -187,7 +187,7 @@
/// Restore the question sessions to their most recent states creating new sessions where required.
if (!$states = get_question_states($questions, $quiz, $attempt, $lastattemptid)) {
print_error('Could not restore question sessions');
print_error('cannotrestore', 'quiz');
}
/// If we are starting a new attempt, save all the newly created states.

12
mod/quiz/comment.php
View File

@ -13,18 +13,18 @@
$questionid =required_param('question', PARAM_INT); // question id
if (! $attempt = $DB->get_record('quiz_attempts', array('uniqueid' => $attemptid))) {
print_error('No such attempt ID exists');
print_error('invalidattemptid', 'quiz');
}
if (! $quiz = $DB->get_record('quiz', array('id' => $attempt->quiz))) {
print_error('Course module is incorrect');
print_error('invalidcoursemodule');
}
if (! $course = $DB->get_record('course', array('id' => $quiz->course))) {
print_error('Course is misconfigured');
print_error('coursemisconf');
}
// Teachers are only allowed to comment and grade on closed attempts
if (!($attempt->timefinish > 0)) {
print_error('Attempt has not closed yet');
print_error('attemptclosed', 'quiz');
}
$cm = get_coursemodule_from_instance('quiz', $quiz->id);
@ -36,7 +36,7 @@
// Load question
if (! $question = $DB->get_record('question', array('id' => $questionid))) {
print_error('Question for this session is missing');
print_error('questionmissing', 'quiz');
}
$question->maxgrade = $DB->get_field('quiz_question_instances', 'grade', array('quiz' => $quiz->id, 'question' => $question->id));
// Some of the questions code is optimised to work with several questions
@ -45,7 +45,7 @@
$questions[$key] = &$question;
// Add additional questiontype specific information to the question objects.
if (!get_question_options($questions)) {
print_error("Unable to load questiontype specific question information");
print_error('cannotloadtypeinfo', 'quiz');
}
// Load state

4
mod/quiz/editlib.php
View File

@ -44,7 +44,7 @@ function quiz_delete_quiz_question($id, &$quiz) {
$quiz->questions = str_replace(',0,0', ',0', $quiz->questions);
// save new questionlist in database
if (!$DB->set_field('quiz', 'questions', $quiz->questions, array('id' => $quiz->instance))) {
print_error('Could not save question list');
print_error('cannotsavequestion', 'quiz');
}
$DB->delete_records('quiz_question_instances', array('quiz' => $quiz->instance, 'question', $question));
return true;
@ -88,7 +88,7 @@ function quiz_add_quiz_question($id, &$quiz) {
// Save new questionslist in database
$quiz->questions = implode(",", $questions);
if (!$DB->set_field('quiz', 'questions', $quiz->questions, array('id' => $quiz->id))) {
print_error('Could not save question list');
print_error('cannotsavequestion', 'quiz');
}
// update question grades

6
mod/quiz/grade.php
View File

@ -5,15 +5,15 @@
$id = required_param('id', PARAM_INT); // Course module ID
if (! $cm = get_coursemodule_from_id('quiz', $id)) {
print_error('Course Module ID was incorrect');
print_error('invalidcoursemodule');
}
if (! $quiz = $DB->get_record('quiz', array('id' => $cm->instance))) {
print_error('quiz ID was incorrect');
print_error('invalidquizid');
}
if (! $course = $DB->get_record('course', array('id' => $quiz->course))) {
print_error('Course is misconfigured');
print_error('coursemisconf');
}
require_login($course->id, false, $cm);

2
mod/quiz/index.php
View File

@ -11,7 +11,7 @@
$id = required_param('id', PARAM_INT);
if (!$course = $DB->get_record('course', array('id' => $id))) {
print_error("Course ID is incorrect");
print_error('invalidcourseid');
}
$coursecontext = get_context_instance(CONTEXT_COURSE, $id);
require_login($course->id);

2
mod/quiz/pagelib.php
View File

@ -20,7 +20,7 @@ class page_quiz extends page_generic_activity {
function init_quick($data) {
if(empty($data->pageid)) {
print_error('Cannot quickly initialize page: empty course id');
print_error('cannotinitpage', '', '', null);
}
$this->activityname = 'quiz';
parent::init_quick($data);

20
mod/quiz/quizfile.php
View File

@ -20,13 +20,13 @@
$relativepath = get_file_argument('quizfile.php');
if (!$relativepath) {
print_error('No valid arguments supplied or incorrect server configuration');
print_error('invalidargorconf');
}
// extract relative path components
$args = explode('/', trim($relativepath, '/'));
if (count($args) < 3) { // always at least category, question and path
print_error('No valid arguments supplied');
print_error('invalidarguments');
}
$quizid = (int)array_shift($args);
@ -34,11 +34,11 @@
$relativepath = implode ('/', $args);
if (!($question = $DB->get_record('question', array('id' => $questionid)))) {
print_error('No valid arguments supplied');
print_error('invalidarguments');
}
if (!($questioncategory = $DB->get_record('question_categories', array('id' => $question->category)))) {
print_error('No valid arguments supplied');
print_error('invalidarguments');
}
/////////////////////////////////////
@ -48,7 +48,7 @@
if ($questioncategory->publish) {
require_login();
if (!isteacherinanycourse()) {
print_error('No valid arguments supplied');
print_error('invalidarguments');
}
} else {
require_login($questioncategory->course);
@ -57,10 +57,10 @@
}
} else {
if (!($quiz = $DB->get_record('quiz', array('id' => $quizid)))) {
print_error('No valid arguments supplied');
print_error('invalidarguments');
}
if (!($course = $DB->get_record('course', array('id' => $quiz->course)))) {
print_error('No valid arguments supplied');
print_error('invalidarguments');
}
require_login($course->id);
@ -71,7 +71,7 @@
// and ! ($quiz->review && time() > $quiz->timeclose)
// || !quiz_get_user_attempts($quiz->id, $USER->id) )
//{
// print_error("Logged-in user is not allowed to view this quiz");
// print_error('noview', 'quiz');
//}
///////////////////////////////////////////////////
@ -82,14 +82,14 @@
// For now, let's not worry about this. The following check doesn't
// work for randomly selected questions and it gets complicated
//if (!in_array($question->id, explode(',', $quiz->questions), FALSE)) {
// print_error("Specified question is not on the specified quiz");
// print_error('specificquestionnotonquiz', 'quiz');
//}
}
// Have the question check whether it uses this file or not
if (!$QTYPES[$question->qtype]->uses_quizfile($question,
$relativepath)) {
print_error("The specified file path is not on the specified question");
print_error('specificapathnotonquestion', 'quiz');
}

16
mod/quiz/report.php
View File

@ -13,26 +13,26 @@
if ($id) {
if (! $cm = get_coursemodule_from_id('quiz', $id)) {
print_error("There is no coursemodule with id $id");
print_error('invalidcoursemodule');
}
if (! $course = $DB->get_record('course', array('id' => $cm->course))) {
print_error("Course is misconfigured");
print_error('coursemisconf');
}
if (! $quiz = $DB->get_record('quiz', array('id' => $cm->instance))) {
print_error("The quiz with id $cm->instance corresponding to this coursemodule $id is missing");
print_error('invalidcoursemodule');
}
} else {
if (! $quiz = $DB->get_record('quiz', array('id' => $q))) {
print_error("There is no quiz with id $q");
print_error('invalidquizid', 'quiz');
}
if (! $course = $DB->get_record('course', array('id' => $quiz->course))) {
print_error("The course with id $quiz->course that the quiz with id $q belongs to is missing");
print_error('invalidcourseid');
}
if (! $cm = get_coursemodule_from_instance("quiz", $quiz->id, $course->id)) {
print_error("The course module for the quiz with id $q is missing");
print_error('invalidcoursemodule');
}
}
@ -62,7 +62,7 @@
$mode = clean_param($mode, PARAM_SAFEDIR);
if (! is_readable("report/$mode/report.php")) {
print_error("Report not known ($mode)");
print_error('reportnotfound', 'quiz', '', $mode);
}
include("report/default.php"); // Parent class
@ -71,7 +71,7 @@
$report = new quiz_report();
if (! $report->display($quiz, $cm, $course)) { // Run the report!
print_error("Error occurred during pre-processing!");
print_error("preprocesserror", 'quiz');
}
/// Print footer

10
mod/quiz/review.php
View File

@ -18,16 +18,16 @@
$showall = optional_param('showall', 0, PARAM_BOOL);
if (!$attempt = quiz_load_attempt($attemptid)) {
print_error("No such attempt ID exists");
print_error('invalidattemptid', 'quiz');
}
if (! $quiz = $DB->get_record('quiz', array('id' => $attempt->quiz))) {
print_error("The quiz with id $attempt->quiz belonging to attempt $attempt is missing");
print_error('invalidquizid', 'quiz');
}
if (! $course = $DB->get_record('course', array('id' => $quiz->course))) {
print_error("The course with id $quiz->course that the quiz with id $quiz->id belongs to is missing");
print_error("invalidcoursemodule");
}
if (! $cm = get_coursemodule_from_instance("quiz", $quiz->id, $course->id)) {
print_error("The course module for the quiz with id $quiz->id is missing");
print_error("invalidcoursemodule");
}
/// Check login and get contexts.
@ -81,7 +81,7 @@
/// Restore the question sessions to their most recent states creating new sessions where required.
if (!$states = get_question_states($questions, $quiz, $attempt)) {
print_error('Could not restore question sessions');
print_error('cannotrestore', 'quiz');
}
/// Work out appropriate title.

24
mod/quiz/reviewquestion.php
View File

@ -21,39 +21,39 @@
if ($stateid) {
if (! $state = $DB->get_record('question_states', array('id' => $stateid))) {
print_error('Invalid state id');
print_error('invalidstateid', 'quiz');
}
if (! $attempt = $DB->get_record('quiz_attempts', array('uniqueid' => $state->attempt))) {
print_error('No such attempt ID exists');
print_error('invalidattemptid', 'quiz');
}
} elseif ($attemptid) {
if (! $attempt = $DB->get_record('quiz_attempts', array('id' => $attemptid))) {
print_error('No such attempt ID exists');
print_error('invalidattemptid', 'quiz');
}
if (! $neweststateid = $DB->get_field('question_sessions', 'newest', array('attemptid' => $attempt->uniqueid, 'questionid' => $questionid))) {
// newest_state not set, probably because this is an old attempt from the old quiz module code
if (! $state = $DB->get_record('question_states', array('question' => $questionid, 'attempt' => $attempt->uniqueid))) {
print_error('Invalid question id');
print_error('invalidquestionid', 'quiz');
}
} else {
if (! $state = $DB->get_record('question_states', array('id' => $neweststateid))) {
print_error('Invalid state id');
print_error('invalidstateid', 'quiz');
}
}
} else {
print_error('Parameter missing');
print_error('missingparameter');
}
if (! $question = $DB->get_record('question', array('id' => $state->question))) {
print_error('Question for this state is missing');
print_error('questionmissing', 'quiz');
}
if (! $quiz = $DB->get_record('quiz', array('id' => $attempt->quiz))) {
print_error('Course module is incorrect');
print_error('invalidcoursemodule');
}
if (! $course = $DB->get_record('course', array('id' => $quiz->course))) {
print_error('Course is misconfigured');
print_error('coursemisconf');
}
if (! $cm = get_coursemodule_from_instance('quiz', $quiz->id, $course->id)) {
print_error('Course Module ID was incorrect');
print_error('invalidcoursemodule');
}
require_login($course->id, false, $cm);
@ -77,7 +77,7 @@
}
}
if ($attempt->userid != $USER->id) {
print_error('This is not your attempt!');
print_error('notyourattempt', 'quiz');
}
}
@ -101,7 +101,7 @@
$questions[$key] = &$question;
// Add additional questiontype specific information to the question objects.
if (!get_question_options($questions)) {
print_error("Unable to load questiontype specific question information");
print_error('cannotloadtypeinfo', 'quiz');
}
$session = $DB->get_record('question_sessions', array('attemptid' => $attempt->uniqueid, 'questionid' => $question->id));

2
mod/quiz/tabs.php
View File

@ -8,7 +8,7 @@
*/
if (empty($quiz)) {
print_error('You cannot call this script in that way');
print_error('cannotcallscript');
}
if (!isset($currenttab)) {
$currenttab = '';

12
mod/quiz/view.php
View File

@ -13,23 +13,23 @@
if ($id) {
if (! $cm = get_coursemodule_from_id('quiz', $id)) {
print_error("There is no coursemodule with id $id");
print_error('invalidcoursemodule');
}
if (! $course = $DB->get_record('course', array('id' => $cm->course))) {
print_error("Course is misconfigured");
print_error('coursemisconf');
}
if (! $quiz = $DB->get_record('quiz', array('id' => $cm->instance))) {
print_error("The quiz with id $cm->instance corresponding to this coursemodule $id is missing");
print_error('invalidcoursemodule');
}
} else {
if (! $quiz = $DB->get_record('quiz', array('id' => $q))) {
print_error("There is no quiz with id $q");
print_error('invalidquizid', 'quiz');
}
if (! $course = $DB->get_record('course', array('id' => $quiz->course))) {
print_error("The course with id $quiz->course that the quiz with id $q belongs to is missing");
print_error('invalidcourseid');
}
if (! $cm = get_coursemodule_from_instance("quiz", $quiz->id, $course->id)) {
print_error("The course module for the quiz with id $q is missing");
print_error('invalidcoursemodule');
}
}