mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-17 21:49:15 +01:00
Code Issues Projects Releases Wiki Activity

MDL-75173 completion: Remove ordering from PHPUnit

Browse Source 
To avoid getting some random errors with Oracle, the order for the
students have been removed from the tests (to check they are there,
regardless the order they are returned, because in that case, the
order is not important).
This commit is contained in:
Sara Arjona 2022-10-18 08:26:45 +02:00
parent 7de314084c
commit 552d687909
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
completion/tests/api_test.php
View File

@ -283,9 +283,10 @@ class api_test extends \advanced_testcase {
$coursecompletionid = \core_completion\api::mark_course_completions_activity_criteria();
$this->assertEquals(0, $coursecompletionid);
$actual = $DB->get_records('course_completions');
$students = [$student1->id, $student2->id];
$this->assertEquals(2, count($actual));
$this->assertEquals($student1->id, reset($actual)->userid);
$this->assertEquals($student2->id, end($actual)->userid);
$this->assertContains(reset($actual)->userid, $students);
$this->assertContains(end($actual)->userid, $students);
}
/**
@ -378,9 +379,10 @@ class api_test extends \advanced_testcase {
$this->assertEquals($student1->id, reset($actual)->userid);
} else {
// Both students completed a course.
$students = [$student1->id, $student2->id];
$this->assertEquals(2, count($actual));
$this->assertEquals($student1->id, reset($actual)->userid);
$this->assertEquals($student2->id, end($actual)->userid);
$this->assertContains(reset($actual)->userid, $students);
$this->assertContains(end($actual)->userid, $students);
}
}
}